stand/zfs: Refactor zfs_get_bootenv
ClosedPublic
Actions

Authored by imp on Apr 4 2023, 6:12 PM.

Details

Reviewers

allanjude
kevans
tsoome
manu

Commits

rG6479bd1b7d34: stand/zfs: Refactor zfs_get_bootenv

Summary

Create a new interface to zfs_get_bootenv called zfs_get_bootenv_spa
which takes a spa instead of a void * (effectively a devdesc *). Use
that in zfs_get_bootenv.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 50754
Build 47645: arc lint + arc unit

Event Timeline

imp created this revision.Apr 4 2023, 6:12 PM

Herald added subscribers: dab, delphij. · View Herald TranscriptApr 4 2023, 6:12 PM

imp requested review of this revision.Apr 4 2023, 6:12 PM

imp added a parent revision: D39408: stand/zfs: Move spa_find_by_dev from zfsimpl.c to zfs.c.

Harbormaster completed remote builds in B50754: Diff 119840.Apr 4 2023, 6:12 PM

imp added a child revision: D39410: stand/zfs: Refactor zfs_set_bootenv.Apr 4 2023, 6:13 PM

imp mentioned this in D39400: efi: Add zfs bootonce support to boot1.efi.Apr 4 2023, 6:16 PM

kevans accepted this revision.Apr 12 2023, 5:06 AM

kevans added inline comments.

stand/libsa/zfs/zfs.c
803	Noting that this changes the return value for a non-ZFS `vdev` from `NOTSUP` to `ENXIO`... I think that's an improvement, though.

This revision is now accepted and ready to land.Apr 12 2023, 5:06 AM

tsoome accepted this revision.Apr 12 2023, 6:20 AM

Closed by commit rG6479bd1b7d34: stand/zfs: Refactor zfs_get_bootenv (authored by imp). · Explain WhyMay 1 2023, 9:04 PM

This revision was automatically updated to reflect the committed changes.

imp added a commit: rG6479bd1b7d34: stand/zfs: Refactor zfs_get_bootenv.

Revision Contents
Changeset List

Path

Size

stand/

libsa/

zfs/

zfs.c

27 lines

zfsimpl.c

30 lines

Diff 119840

View Options

stand/libsa/zfs/zfs.c