Page MenuHomeFreeBSD
Differential D39413

rc.d/zfsbe: Simplify
ClosedPublic
Actions

Authored by imp on Apr 4 2023, 6:13 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Oct 2, 9:11 PM
Unknown Object (File)
Sun, Sep 28, 10:16 PM
Unknown Object (File)
Sun, Sep 28, 10:04 PM
Unknown Object (File)
Sun, Sep 28, 9:32 PM
Unknown Object (File)
Sun, Sep 28, 9:01 PM
Unknown Object (File)
Sun, Sep 28, 8:58 PM
Unknown Object (File)
Sat, Sep 27, 1:24 PM
Unknown Object (File)
Fri, Sep 26, 9:31 PM
View All 79 Files
Subscribers
jlduran

Details

Reviewers
allanjude
kevans
tsoome
manu
Commits
rG0c4183f02efc: rc.d/zfsbe: Simplify
Summary

So $(foo) is a shorter version of "foo".

Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

imp requested review of this revision.Apr 4 2023, 6:13 PM
imp created this revision.
imp added a parent revision: D39412: stand/boot1.efi: Implement bootonce for ZFS.
imp added a child revision: D39414: stand/userboot: Simplify code.
Harbormaster completed remote builds in B50758: Diff 119844.Apr 4 2023, 6:13 PM
imp mentioned this in D39400: efi: Add zfs bootonce support to boot1.efi.Apr 4 2023, 6:16 PM
jlduran added a subscriber: jlduran.Apr 4 2023, 6:29 PM
jlduran added inline comments.
libexec/rc/rc.d/zfsbe
60

Should we still keep the double quotes? (To to prevent globbing and word splitting as shellsheck would say, although unlikely).

imp added inline comments.Apr 4 2023, 8:38 PM
libexec/rc/rc.d/zfsbe
60

Are they needed here? Word expansion doesn't happen here after the substitution, so _bootonce will have whatever is the value of zfs-bootonce, even if there's spaces.

jlduran added inline comments.Apr 4 2023, 10:07 PM
libexec/rc/rc.d/zfsbe
60

Are they needed here?

Unlikely.

This revision was not accepted when it landed; it landed in state Needs Review.May 1 2023, 9:04 PM
Closed by commit rG0c4183f02efc: rc.d/zfsbe: Simplify (authored by imp). · Explain Why
This revision was automatically updated to reflect the committed changes.
imp added a commit: rG0c4183f02efc: rc.d/zfsbe: Simplify.

Revision Contents
Changeset List

PathSize
libexec/
rc/
rc.d/
2 lines

Diff 121347

View Options

libexec/rc/rc.d/zfsbe

Loading...