Paths

Table of Contentst

Differential D37819

Mechanically convert qlxge(4) to DrvAPI
ClosedPublic
Actions

Authored by jhibbits on Dec 22 2022, 3:30 PM.

Tags

None

Referenced Files

	F163352705: D37819.id.diff
	Wed, Jul 22, 10:32 AM

	Unknown Object (File)
	Tue, Jul 21, 12:46 PM

	Unknown Object (File)
	Tue, Jul 21, 8:23 AM

	Unknown Object (File)
	Mon, Jul 20, 8:11 AM

	Unknown Object (File)
	Thu, Jul 16, 8:18 PM

	Unknown Object (File)
	Sat, Jul 11, 2:25 PM

	Unknown Object (File)
	Sat, Jul 11, 2:25 PM

	Unknown Object (File)
	Thu, Jul 2, 1:32 AM

Subscribers

Details

Reviewers

Group Reviewers

Commits

rG64c618ed7dbb: Mechanically convert qlxge(4) to IfAPI

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhibbits created this revision.Dec 22 2022, 3:30 PM

Herald added a subscriber: imp. · View Herald TranscriptDec 22 2022, 3:30 PM

jhibbits requested review of this revision.Dec 22 2022, 3:30 PM

Harbormaster completed remote builds in B48831: Diff 114445.Dec 22 2022, 3:30 PM

jhibbits added a parent revision: D37818: Mechanically convert sk(4) to DrvAPI.Dec 22 2022, 3:30 PM

jhibbits added a child revision: D37820: Mechanically convert qlxgb(4) to DrvAPI.

jhibbits added a reviewer: network.Feb 6 2023, 7:40 PM

Other parts looks good to me.

sys/dev/qlxge/qls_os.c
306	`if_sendq_empty(ifp)` seems not identical to `ifp->if_snd.ifq_head == NULL`
1086–1087	Ditto

This revision is now accepted and ready to land.Feb 7 2023, 1:42 AM

zlei mentioned this in D37820: Mechanically convert qlxgb(4) to DrvAPI.Feb 7 2023, 1:48 AM

jhibbits added inline comments.Feb 7 2023, 3:27 PM

sys/dev/qlxge/qls_os.c
306	It looks like the difference is that `if_sendq_empty()`, which uses `IFQ_DRV_IS_EMPTY()` also checks `ifq_drv_len` in addition to `ifq_len`. I don't know the impact of this difference.

jhibbits added inline comments.Feb 7 2023, 6:57 PM

sys/dev/qlxge/qls_os.c
306	Reviewing, I think `if_sendq_empty()` is safe and correct.

Closed by commit rG64c618ed7dbb: Mechanically convert qlxge(4) to IfAPI (authored by jhibbits). · Explain WhyMar 7 2023, 8:29 PM

This revision was automatically updated to reflect the committed changes.

jhibbits added a commit: rG64c618ed7dbb: Mechanically convert qlxge(4) to IfAPI.

Revision Contents
Changeset List

Path

Size

sys/

dev/

qlxge/

4 lines

2 lines

2 lines

4 lines

149 lines

Diff 118490

sys/dev/qlxge/qls_def.h

Loading...

sys/dev/qlxge/qls_hw.c

Loading...

sys/dev/qlxge/qls_ioctl.c

Loading...

sys/dev/qlxge/qls_isr.c

Loading...

sys/dev/qlxge/qls_os.c

Loading...