Differential D38855

bhyve: [snapshot] Do not flush readonly device at blockif_pause()
ClosedPublic
Actions

Authored by gusev.vitaliy_gmail.com on Mar 2 2023, 6:08 PM.

Tags

Referenced Files

	Unknown Object (File)
	Sat, May 4, 6:04 PM

	Unknown Object (File)
	Thu, May 2, 2:31 AM

	Unknown Object (File)
	Thu, May 2, 2:31 AM

	Unknown Object (File)
	Thu, May 2, 2:03 AM

	Unknown Object (File)
	Thu, May 2, 1:07 AM

	Unknown Object (File)
	Wed, May 1, 11:27 PM

	Unknown Object (File)
	Thu, Apr 25, 3:21 PM

	Unknown Object (File)
	Thu, Apr 25, 3:21 PM

View All 30 Files

Subscribers

Details

Reviewers

corvink
jhb
markj

Group Reviewers

Commits

rGc8b5f347317d: bhyve: don't flush readonly device at blockif_pause
rG5c0a03125988: bhyve: don't flush readonly device at blockif_pause

Summary

Part of Capsicum integration for snapshots.

Eliminates error:

blockif_pause: [WARN] failed to flush backing file.

Sponsored by: vStack

Test Plan

Compile, run VM, suspend/resume.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

gusev.vitaliy_gmail.com created this revision.Mar 2 2023, 6:08 PM

Herald added a reviewer: bhyve. · View Herald TranscriptMar 2 2023, 6:08 PM

Herald added subscribers: bcran, rgrimes, imp. · View Herald Transcript

gusev.vitaliy_gmail.com requested review of this revision.Mar 2 2023, 6:08 PM

gusev.vitaliy_gmail.com mentioned this in D35454: bhyve: snapshot capsicum support.Mar 2 2023, 6:49 PM

gusev.vitaliy_gmail.com added a child revision: D38856: bhyve: [snapshot] Add cap limits for ipc socket.Mar 2 2023, 8:30 PM

gusev.vitaliy_gmail.com added a parent revision: D38866: libvmm: Add missed ioctl to vm_ioctl_cmds.

markj accepted this revision as: markj.Mar 2 2023, 9:55 PM

markj added inline comments.

usr.sbin/bhyve/block_if.c
1012	BTW, the BOP_FLUSH handler does not check whether the device is read-only before calling blockif_flush_bc(). Perhaps it should be a no-op in that situation?

This revision is now accepted and ready to land.Mar 2 2023, 9:55 PM

corvink accepted this revision.Mar 3 2023, 7:02 AM

gusev.vitaliy_gmail.com marked an inline comment as done.Mar 3 2023, 11:43 AM

gusev.vitaliy_gmail.com added inline comments.

usr.sbin/bhyve/block_if.c
1012	BOP_FLUSH() is called when emulated device directly calls blockif_flush(). Look at ahci_handle_flush() and nvme_opc_flush()) or pci_vtblk_proc(). In all cases it is just handle of guest's requests. So guest is aware about readonly device and shouldn't call flush commands.

gusev.vitaliy_gmail.com marked an inline comment as done.Mar 3 2023, 11:43 AM

Closed by commit rG5c0a03125988: bhyve: don't flush readonly device at blockif_pause (authored by gusev.vitaliy_gmail.com, committed by corvink). · Explain WhyMar 6 2023, 1:06 PM

This revision was automatically updated to reflect the committed changes.

corvink added a commit: rG5c0a03125988: bhyve: don't flush readonly device at blockif_pause.

corvink added a commit: rGc8b5f347317d: bhyve: don't flush readonly device at blockif_pause.Mar 17 2023, 10:31 AM

Revision Contents
Changeset List

Path

Size

usr.sbin/

bhyve/

2 lines

Diff 118382

usr.sbin/bhyve/block_if.c

Loading...