Page MenuHomeFreeBSD
Differential D38824

Actually get/set the correct values when inquiring TCP_PCAP_[IN/OUT]
ClosedPublic
Actions

Authored by rscheff on Feb 28 2023, 5:07 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jul 10, 11:41 AM
Unknown Object (File)
Wed, Jul 8, 1:33 AM
Unknown Object (File)
Mon, Jul 6, 5:52 AM
Unknown Object (File)
Thu, Jun 18, 3:00 AM
Unknown Object (File)
Tue, Jun 16, 1:59 AM
Unknown Object (File)
Jun 8 2026, 9:39 PM
Unknown Object (File)
Jun 8 2026, 3:58 AM
Unknown Object (File)
May 21 2026, 9:13 AM
View All Files
Subscribers
imp
melifaro

Details

Reviewers
tuexen
glebius
cc
rrs
jtl
Group Reviewers
transport
Commits
rG9b3d6127716e: tcp: Make TCP PCAP buffer properly configurable.
rG2be7e3df7275: tcp: Make TCP PCAP buffer properly configurable.
rG399a5655e6ed: tcp: Make TCP PCAP buffer properly configurable.
Summary

Just stumbled upon this while looking at sources.

Seems like a fleeting error trying to reference the sopt_name implicitly.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 50068
Build 46960: arc lint + arc unit

Event Timeline

rscheff created this revision.Feb 28 2023, 5:07 PM
Herald added a reviewer: transport. · View Herald TranscriptFeb 28 2023, 5:07 PM
Herald added subscribers: melifaro, imp. · View Herald Transcript
rscheff requested review of this revision.Feb 28 2023, 5:07 PM
Harbormaster completed remote builds in B50067: Diff 118086.Feb 28 2023, 5:07 PM
cc requested changes to this revision.Feb 28 2023, 5:48 PM
cc added inline comments.
sys/netinet/tcp_usrreq.c
1669

This shall not compile. Dropped this line by accident?

This revision now requires changes to proceed.Feb 28 2023, 5:48 PM
rscheff updated this revision to Diff 118087.Feb 28 2023, 5:55 PM
  • remove fat-finger line deletion
Harbormaster completed remote builds in B50068: Diff 118087.Feb 28 2023, 5:55 PM
tuexen accepted this revision.Feb 28 2023, 6:23 PM
glebius accepted this revision.Feb 28 2023, 8:09 PM

Looks a trivial fix to me, that doesn't need a review to be checked in.

cc accepted this revision.Feb 28 2023, 8:15 PM
This revision is now accepted and ready to land.Feb 28 2023, 8:15 PM
Closed by commit rG399a5655e6ed: tcp: Make TCP PCAP buffer properly configurable. (authored by rscheff). · Explain WhyFeb 28 2023, 8:16 PM
This revision was automatically updated to reflect the committed changes.
rscheff added a commit: rG399a5655e6ed: tcp: Make TCP PCAP buffer properly configurable..
rscheff added a commit: rG2be7e3df7275: tcp: Make TCP PCAP buffer properly configurable..Mar 3 2023, 9:29 PM
rscheff added a commit: rG9b3d6127716e: tcp: Make TCP PCAP buffer properly configurable..

Revision Contents
Changeset List

PathSize
sys/
netinet/
6 lines

Diff 118087

View Options

sys/netinet/tcp_usrreq.c

Loading...