Paths

Table of Contentst

Differential D28703

Allow sysctl hw.machine/hw.machine_arch in capability mode
ClosedPublic
Actions

Authored by val_packett.cool on Feb 16 2021, 2:41 PM.

Tags

None

Referenced Files

	F131277499: D28703.diff
	Mon, Oct 6, 12:03 PM

	Unknown Object (File)
	Sat, Oct 4, 8:47 AM

	Unknown Object (File)
	Sat, Sep 27, 8:52 PM

	Unknown Object (File)
	Thu, Sep 18, 2:44 AM

	Unknown Object (File)
	Wed, Sep 17, 2:33 PM

	Unknown Object (File)
	Tue, Sep 16, 11:02 PM

	Unknown Object (File)
	Tue, Sep 16, 6:53 PM

	Unknown Object (File)
	Sun, Sep 7, 2:57 PM

Subscribers

Details

Reviewers

manu
emaste
andrew

Group Reviewers

Contributor Reviews (src)
capsicum

Commits

rG313bd4df8b13: mips: Allow sysctl hw.machine in capability mode
rGf7dd97b7e227: Allow sysctl hw.machine/hw.machine_arch in capability mode
rG4a1c4de232af: Allow sysctl hw.machine/hw.machine_arch in capability mode

Summary

There's no harm in reading strings like 'amd64'.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 49538
Build 46428: arc lint + arc unit

Event Timeline

val_packett.cool created this revision.Feb 16 2021, 2:41 PM

Herald added a reviewer: manu. · View Herald TranscriptFeb 16 2021, 2:41 PM

Herald added subscribers: jhibbits, emaste, andrew. · View Herald Transcript

Harbormaster completed remote builds in B37051: Diff 84012.Feb 16 2021, 2:41 PM

val_packett.cool requested review of this revision.Feb 16 2021, 2:41 PM

val_packett.cool added reviewers: emaste, Contributor Reviews (src).Feb 16 2021, 2:42 PM

val_packett.cool set the repository for this revision to rG FreeBSD src repository.

val_packett.cool added a reviewer: capsicum.Feb 16 2021, 3:12 PM

LGTM

This revision is now accepted and ready to land.Feb 16 2021, 5:08 PM

rebased (bye bye MIPS \o/). ping!

This revision now requires review to proceed.Feb 5 2023, 8:54 PM

Herald added a subscriber: imp. · View Herald TranscriptFeb 5 2023, 8:54 PM

Harbormaster completed remote builds in B49538: Diff 116540.Feb 5 2023, 8:54 PM

emaste accepted this revision.Feb 6 2023, 3:10 PM

This revision is now accepted and ready to land.Feb 6 2023, 3:10 PM

Do you have a public Git branch somewhere that I can fetch your changes from?

In D28703#873145, @emaste wrote:

Do you have a public Git branch somewhere that I can fetch your changes from?

ok, now I do, at https://codeberg.org/valpackett/freebsd-src right now.

What *is* the deal with phab and git metadata after all D: Why can I *sometimes* arc patch with author data and all the things but it's still weird?

Closed by commit rG4a1c4de232af: Allow sysctl hw.machine/hw.machine_arch in capability mode (authored by val_packett.cool, committed by emaste). · Explain WhyFeb 6 2023, 7:01 PM

This revision was automatically updated to reflect the committed changes.

emaste added a commit: rG4a1c4de232af: Allow sysctl hw.machine/hw.machine_arch in capability mode.

What *is* the deal with phab and git metadata after all D: Why can I *sometimes* arc patch with author data and all the things but it's still weird?

I don't know - as far as I'm aware there's no usable way to transport git metadata in and out of phab.

emaste mentioned this in D43281: x86: Export cpu_model[].Jan 3 2024, 12:57 AM

This can also apply to stable/13 branch. Do you have plan MFC the commit ?

Herald added a reviewer: andrew. · View Herald TranscriptSep 20 2024, 10:01 AM

Herald added a reviewer: andrew. · View Herald Transcript

Herald added subscribers: riscv, olce. · View Herald Transcript

This can also apply to stable/13 branch. Do you have plan MFC the commit ?

I can, sure.

emaste added a commit: rGf7dd97b7e227: Allow sysctl hw.machine/hw.machine_arch in capability mode.Sep 20 2024, 12:20 PM

In D28703#1065057, @emaste wrote:

This can also apply to stable/13 branch. Do you have plan MFC the commit ?

I can, sure.

Thanks !

@emaste I'd like to do a direct commit to stable/13 branch for the mips part. The very first revision actually has change for mips arch, and @manu accepted that.
Any objections ?

I'd like to do a direct commit to stable/13 branch for the mips part.

Oh, please go ahead. I forgot about mips.

zlei added a commit: rG313bd4df8b13: mips: Allow sysctl hw.machine in capability mode.Sep 20 2024, 3:28 PM

In D28703#1065140, @emaste wrote:

I'd like to do a direct commit to stable/13 branch for the mips part.

Oh, please go ahead. I forgot about mips.

Landed.

Revision Contents
Changeset List

Path

Size

sys/

arm/

arm/

2 lines

arm64/

arm64/

3 lines

kern/

2 lines

powerpc/

powerpc/

2 lines

riscv/

riscv/

2 lines

x86/

x86/

4 lines

Diff 116540

sys/arm/arm/identcpu-v6.c

Loading...

sys/arm64/arm64/identcpu.c

Loading...

sys/kern/kern_mib.c

Loading...

sys/powerpc/powerpc/machdep.c

Loading...

sys/riscv/riscv/identcpu.c

Loading...

sys/x86/x86/identcpu.c

Loading...