Page MenuHomeFreeBSD
Differential D38367

Better error checking in code example.
ClosedPublic
Actions

Authored by pauamma_gundo.com on Feb 3 2023, 2:09 AM.
Tags
None
Referenced Files
F102642769: D38367.diff
Fri, Nov 15, 6:04 AM
Unknown Object (File)
Wed, Nov 6, 3:40 PM
Unknown Object (File)
Sep 27 2024, 1:05 PM
Unknown Object (File)
Sep 18 2024, 2:50 PM
Unknown Object (File)
Sep 18 2024, 12:18 AM
Unknown Object (File)
Sep 6 2024, 8:39 AM
Unknown Object (File)
Sep 6 2024, 3:19 AM
Unknown Object (File)
Sep 2 2024, 10:10 PM
View All 44 Files
Subscribers
imp
lwhsu

Details

Reviewers
carlavilla
gjb
dim
bdrewery
markj
Group Reviewers
manpages
Commits
rG258c6d5e9b98: filemon(4): Better error checking in code example
Summary

Discussed with dim

Test Plan

igor # no output
man
mandoc -T lint # only unrelated warnings
clang -Wall -c example-with-static-removed.c # no errors or warnings

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 49518
Build 46408: arc lint + arc unit

Event Timeline

pauamma_gundo.com created this revision.Feb 3 2023, 2:09 AM
Herald added a subscriber: imp. · View Herald TranscriptFeb 3 2023, 2:09 AM
pauamma_gundo.com requested review of this revision.Feb 3 2023, 2:09 AM
Harbormaster completed remote builds in B49503: Diff 116382.Feb 3 2023, 2:09 AM
markj accepted this revision.Feb 3 2023, 2:36 PM

Seems ok to me otherwise.

share/man/man4/filemon.4
222

I don't think this cast is needed?

225

Same here. You can assume that comparing a pid_t to -1 will do the right thing.

This revision is now accepted and ready to land.Feb 3 2023, 2:36 PM
pauamma_gundo.com marked 2 inline comments as done.Feb 3 2023, 10:48 PM
pauamma_gundo.com updated this revision to Diff 116444.Feb 3 2023, 10:49 PM
  • Remove unneeded cast.
This revision now requires review to proceed.Feb 3 2023, 10:49 PM
Harbormaster completed remote builds in B49518: Diff 116444.Feb 3 2023, 10:49 PM
markj accepted this revision.Feb 4 2023, 6:27 PM
This revision is now accepted and ready to land.Feb 4 2023, 6:27 PM
pauamma_gundo.com added a comment.Feb 5 2023, 3:04 PM

Over to mentors

pauamma_gundo.com added a comment.Feb 14 2023, 8:04 PM
In D38367#872754, @pauamma wrote:

Over to mentors

ping @carlavilla @gjb

pauamma_gundo.com added a comment.Mar 6 2023, 10:51 AM
In D38367#878182, @pauamma wrote:
In D38367#872754, @pauamma wrote:

Over to mentors

ping @carlavilla @gjb

@carlavilla, @gjb, do I need to do anything to move this forward?

pauamma_gundo.com added a comment.Mar 21 2023, 11:26 PM

Can a committer take this? My commit access was revoked.

lwhsu added a subscriber: lwhsu.Aug 1 2023, 1:58 PM
Closed by commit rG258c6d5e9b98: filemon(4): Better error checking in code example (authored by pauamma_gundo.com, committed by mhorne). · Explain WhyAug 1 2023, 2:31 PM
This revision was automatically updated to reflect the committed changes.
mhorne added a commit: rG258c6d5e9b98: filemon(4): Better error checking in code example.

Revision Contents
Changeset List

PathSize
share/
man/
man4/
15 lines

Diff 116444

View Options

share/man/man4/filemon.4

Loading...