Page MenuHomeFreeBSD

Better error checking in code example.
ClosedPublic

Authored by pauamma_gundo.com on Feb 3 2023, 2:09 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jun 5, 2:51 PM
Unknown Object (File)
Wed, Jun 5, 2:16 PM
Unknown Object (File)
Wed, Jun 5, 2:14 PM
Unknown Object (File)
May 4 2024, 6:56 PM
Unknown Object (File)
Mar 27 2024, 6:37 AM
Unknown Object (File)
Mar 9 2024, 11:24 PM
Unknown Object (File)
Mar 9 2024, 4:27 PM
Unknown Object (File)
Feb 27 2024, 12:25 PM
Subscribers

Details

Summary

Discussed with dim

Test Plan

igor # no output
man
mandoc -T lint # only unrelated warnings
clang -Wall -c example-with-static-removed.c # no errors or warnings

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Seems ok to me otherwise.

share/man/man4/filemon.4
222

I don't think this cast is needed?

225

Same here. You can assume that comparing a pid_t to -1 will do the right thing.

This revision is now accepted and ready to land.Feb 3 2023, 2:36 PM
This revision now requires review to proceed.Feb 3 2023, 10:49 PM
This revision is now accepted and ready to land.Feb 4 2023, 6:27 PM
In D38367#878182, @pauamma wrote:
In D38367#872754, @pauamma wrote:

Over to mentors

ping @carlavilla @gjb

@carlavilla, @gjb, do I need to do anything to move this forward?

Can a committer take this? My commit access was revoked.