Paths

Table of Contentst

Better error checking in code example.
ClosedPublic
Actions

Authored by pauamma_gundo.com on Feb 3 2023, 2:09 AM.

Details

Reviewers

carlavilla
gjb
dim
bdrewery
markj

Group Reviewers

manpages

Commits

rG258c6d5e9b98: filemon(4): Better error checking in code example

Summary

Discussed with dim

Test Plan

igor # no output
man
mandoc -T lint # only unrelated warnings
clang -Wall -c example-with-static-removed.c # no errors or warnings

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

pauamma_gundo.com created this revision.Feb 3 2023, 2:09 AM

Herald added a subscriber: imp. · View Herald TranscriptFeb 3 2023, 2:09 AM

pauamma_gundo.com requested review of this revision.Feb 3 2023, 2:09 AM

Harbormaster completed remote builds in B49503: Diff 116382.Feb 3 2023, 2:09 AM

Seems ok to me otherwise.

share/man/man4/filemon.4
222	I don't think this cast is needed?
225	Same here. You can assume that comparing a `pid_t` to -1 will do the right thing.

This revision is now accepted and ready to land.Feb 3 2023, 2:36 PM

pauamma_gundo.com marked 2 inline comments as done.Feb 3 2023, 10:48 PM

Remove unneeded cast.

This revision now requires review to proceed.Feb 3 2023, 10:49 PM

Harbormaster completed remote builds in B49518: Diff 116444.Feb 3 2023, 10:49 PM

markj accepted this revision.Feb 4 2023, 6:27 PM

This revision is now accepted and ready to land.Feb 4 2023, 6:27 PM

Over to mentors

In D38367#872754, @pauamma wrote:

Over to mentors

ping @carlavilla @gjb

In D38367#878182, @pauamma wrote:

In D38367#872754, @pauamma wrote:

Over to mentors

ping @carlavilla @gjb

@carlavilla, @gjb, do I need to do anything to move this forward?

Can a committer take this? My commit access was revoked.

lwhsu added a subscriber: lwhsu.Aug 1 2023, 1:58 PM

Closed by commit rG258c6d5e9b98: filemon(4): Better error checking in code example (authored by pauamma_gundo.com, committed by mhorne). · Explain WhyAug 1 2023, 2:31 PM

This revision was automatically updated to reflect the committed changes.

mhorne added a commit: rG258c6d5e9b98: filemon(4): Better error checking in code example.

Revision Contents
Changeset List

Path

Size

share/

man/

man4/

filemon.4

15 lines

Diff 125418

View Options

Better error checking in code example.ClosedPublicActions