hyperv: Build and install where supported
ClosedPublic
Actions

Authored by imp on Jan 31 2023, 10:39 PM.

Details

Reviewers

Commits

rGf051d72314f8: hyperv: Build and install where supported

Summary

Remove the hard-coded dependency on HYPERV being only x86. Instead, 100%
rely on MK_HYPERV. It's always right (since it's marked BROKEN (so set
to "no") on architectures we don't support).

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 49375
Build 46265: arc lint + arc unit

Event Timeline

imp requested review of this revision.Jan 31 2023, 10:39 PM

imp created this revision.

Harbormaster completed remote builds in B49375: Diff 116151.Jan 31 2023, 10:39 PM

imp added a reviewer: bz.Jan 31 2023, 10:40 PM

Looks good to me; I'll test within the next 24 hours if that helps.

In D38306#870384, @bz wrote:

Looks good to me; I'll test within the next 24 hours if that helps.

Please do. Let me know. I'll commit tomorrow.

Ok, started a native and a cross-build (assuming no build breakage) to also test another fix for something else. Should know "in the morning" and will let you know.

Okay, I am confused about what the correct outcome should be but likely it is a pilot error on etcupdate on my behalf.

Neither on amd64 nor arm64 etcupdate did re-install the removed /etc/devd/hyperv.conf file. I tried mergemaster on amd64 and that did install it back.
On both amd64 and arm64 I do have files in /usr/libexec/hyperv/ now so that should be fine.

I believe this solves the issue and I need to figure out how to tell etcupdate to restore manually removed files again ... @jhb ?

This revision is now accepted and ready to land.Feb 1 2023, 1:40 PM

Closed by commit rGf051d72314f8: hyperv: Build and install where supported (authored by imp). · Explain WhyFeb 1 2023, 5:24 PM

This revision was automatically updated to reflect the committed changes.

imp added a commit: rGf051d72314f8: hyperv: Build and install where supported.