Page MenuHomeFreeBSD

hyperv: Build and install where supported
ClosedPublic

Authored by imp on Jan 31 2023, 10:39 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jun 3, 8:22 PM
Unknown Object (File)
Apr 29 2024, 10:48 PM
Unknown Object (File)
Apr 29 2024, 8:36 AM
Unknown Object (File)
Dec 20 2023, 8:28 AM
Unknown Object (File)
Dec 18 2023, 9:41 AM
Unknown Object (File)
Dec 12 2023, 12:10 PM
Unknown Object (File)
Jul 25 2023, 7:55 AM
Unknown Object (File)
Jul 24 2023, 7:20 PM
Subscribers

Details

Summary

Remove the hard-coded dependency on HYPERV being only x86. Instead, 100%
rely on MK_HYPERV. It's always right (since it's marked BROKEN (so set
to "no") on architectures we don't support).

Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

imp requested review of this revision.Jan 31 2023, 10:39 PM
imp created this revision.

Looks good to me; I'll test within the next 24 hours if that helps.

In D38306#870384, @bz wrote:

Looks good to me; I'll test within the next 24 hours if that helps.

Please do. Let me know. I'll commit tomorrow.

Ok, started a native and a cross-build (assuming no build breakage) to also test another fix for something else. Should know "in the morning" and will let you know.

bz added a subscriber: jhb.

Okay, I am confused about what the correct outcome should be but likely it is a pilot error on etcupdate on my behalf.

Neither on amd64 nor arm64 etcupdate did re-install the removed /etc/devd/hyperv.conf file. I tried mergemaster on amd64 and that did install it back.
On both amd64 and arm64 I do have files in /usr/libexec/hyperv/ now so that should be fine.

I believe this solves the issue and I need to figure out how to tell etcupdate to restore manually removed files again ... @jhb ?

This revision is now accepted and ready to land.Feb 1 2023, 1:40 PM
This revision was automatically updated to reflect the committed changes.