Page MenuHomeFreeBSD
Differential D37399

Support the arm64 pmap_remove_write for stage 2
ClosedPublic
Actions

Authored by andrew on Nov 15 2022, 6:06 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 20 2024, 1:16 AM
Unknown Object (File)
Feb 20 2024, 1:16 AM
Unknown Object (File)
Feb 20 2024, 1:16 AM
Unknown Object (File)
Feb 20 2024, 1:16 AM
Unknown Object (File)
Feb 20 2024, 1:02 AM
Unknown Object (File)
Jan 12 2024, 8:21 AM
Unknown Object (File)
Dec 27 2023, 3:39 PM
Unknown Object (File)
Dec 23 2023, 1:44 AM
View All 30 Files
Subscribers
emaste
imp

Details

Reviewers
kib
markj
alc
manu
Group Reviewers
arm64
Commits
rG51308cd29b3b: Support the arm64 pmap_remove_write for stage 2
Summary

The fields we need to adjust are different in stage 1 and stage 2
tables. Handle this by adding variables to hold the bits to check,
set, and clear.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 48400
Build 45286: arc lint + arc unit

Event Timeline

andrew created this revision.Nov 15 2022, 6:06 PM
Herald added a reviewer: manu. · View Herald TranscriptNov 15 2022, 6:06 PM
Herald added subscribers: emaste, imp. · View Herald Transcript
andrew requested review of this revision.Nov 15 2022, 6:06 PM
andrew added a parent revision: D37254: Support arm64 stage2 TLB invalidation.Nov 15 2022, 6:06 PM
Harbormaster completed remote builds in B48370: Diff 113152.Nov 15 2022, 6:07 PM
kib accepted this revision.Nov 16 2022, 5:25 AM

You might take a look at PG_RW/PG_V, pmap_valid_bit()/pmap_rw_bit() in amd64 pmap.

This revision is now accepted and ready to land.Nov 16 2022, 5:25 AM
alc added inline comments.Nov 16 2022, 7:20 AM
sys/arm64/arm64/pmap.c
5773

This is incorrect. ATTR_S1_AP(ATTR_S1_AP_RW) is equal to 0. So, the original code calls vm_page_dirty() if (oldpte & ATTR_S1_AP_RW_BIT) == 0.

andrew updated this revision to Diff 113229.Nov 17 2022, 12:17 PM

Fix the check before calling vm_page_dirty

This revision now requires review to proceed.Nov 17 2022, 12:17 PM
Harbormaster completed remote builds in B48400: Diff 113229.Nov 17 2022, 12:17 PM
alc accepted this revision.Nov 20 2022, 1:16 AM
This revision is now accepted and ready to land.Nov 20 2022, 1:16 AM
Closed by commit rG51308cd29b3b: Support the arm64 pmap_remove_write for stage 2 (authored by andrew). · Explain WhyMar 15 2023, 3:49 PM
This revision was automatically updated to reflect the committed changes.
andrew added a commit: rG51308cd29b3b: Support the arm64 pmap_remove_write for stage 2.

Revision Contents
Changeset List

PathSize
sys/
arm64/
arm64/
23 lines

Diff 113229

View Options

sys/arm64/arm64/pmap.c

Loading...