Page MenuHomeFreeBSD

Support the arm64 pmap_remove_write for stage 2
AcceptedPublic

Authored by andrew on Tue, Nov 15, 6:06 PM.

Details

Reviewers
kib
markj
alc
manu
Group Reviewers
arm64
Summary

The fields we need to adjust are different in stage 1 and stage 2
tables. Handle this by adding variables to hold the bits to check,
set, and clear.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 48400
Build 45286: arc lint + arc unit

Event Timeline

You might take a look at PG_RW/PG_V, pmap_valid_bit()/pmap_rw_bit() in amd64 pmap.

This revision is now accepted and ready to land.Wed, Nov 16, 5:25 AM
sys/arm64/arm64/pmap.c
5773

This is incorrect. ATTR_S1_AP(ATTR_S1_AP_RW) is equal to 0. So, the original code calls vm_page_dirty() if (oldpte & ATTR_S1_AP_RW_BIT) == 0.

Fix the check before calling vm_page_dirty

This revision now requires review to proceed.Thu, Nov 17, 12:17 PM
This revision is now accepted and ready to land.Sun, Nov 20, 1:16 AM