Details

Reviewers

rrs
jtl
glebius
• hselasky
tuexen

Group Reviewers

transport

Commits

rG1a70101a8700: tcp: account sent/received IP ECN markings independently

Summary

TCPS (netstat -s) would not differentiate between received and sent
ECN-marked packets, but would only account received packets if the
tcp session had negotiated ECN support.

It is known that some devices incorrectly set the historic TOS byte
and may infringe on the IP ECN bits - but without accounting IP ECN
packets where the session is not ECN-enabled would mask such misconfigurations.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 48242
Build 45128: arc lint + arc unit

Event Timeline

rscheff created this revision.Nov 9 2022, 11:22 AM

Herald added a reviewer: transport. · View Herald TranscriptNov 9 2022, 11:22 AM

Herald added subscribers: melifaro, imp. · View Herald Transcript

rscheff requested review of this revision.Nov 9 2022, 11:22 AM

Harbormaster completed remote builds in B48239: Diff 112798.Nov 9 2022, 11:22 AM

rscheff added inline comments.Nov 9 2022, 12:08 PM

sys/netinet/tcp_var.h
828	not sure if we will need a sent ce counter - this may only be relevant for future CC where a receiver driving marking is also possible. Or for path probing...

remove tcps_ecn_sndce

Harbormaster completed remote builds in B48240: Diff 112801.Nov 9 2022, 3:32 PM

tuexen added inline comments.Nov 9 2022, 3:46 PM

sys/netinet/tcp_ecn.c
124	Why are you removing this line?
sys/netinet/tcp_var.h
831	I think you want to go from 6 to 4 now, not to 3. However, wasn't the plan to not change this at all in the main branch?
usr.bin/netstat/inet.c
831	Don't you need to change the `"\t{:*/%ju} "` stuff?