Page MenuHomeFreeBSD
Differential D37280

tcp: add AccECN CE packet counter to tcpinfo
ClosedPublic
Actions

Authored by rscheff on Nov 5 2022, 10:41 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 31, 8:15 AM
Unknown Object (File)
Feb 10 2025, 5:21 PM
Unknown Object (File)
Feb 9 2025, 6:30 AM
Unknown Object (File)
Feb 3 2025, 11:08 PM
Unknown Object (File)
Feb 2 2025, 11:01 PM
Unknown Object (File)
Feb 2 2025, 10:57 PM
Unknown Object (File)
Feb 2 2025, 8:32 PM
Unknown Object (File)
Jan 28 2025, 7:11 PM
View All 59 Files
Subscribers
glebius
imp
melifaro

Details

Reviewers
tuexen
thj
Group Reviewers
transport
Commits
rG22c81cc51636: tcp: add AccECN CE packet counters to tcpinfo
Summary

Provide diagnostics information around AccECN into
the tcpinfo struct.

Event: IETF 115 Hackathon
Sponsored by: NetApp, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 48185
Build 45072: arc lint + arc unit

Event Timeline

rscheff created this revision.Nov 5 2022, 10:41 AM
Herald added a reviewer: transport. · View Herald TranscriptNov 5 2022, 10:41 AM
Herald added subscribers: glebius, melifaro, imp. · View Herald Transcript
rscheff requested review of this revision.Nov 5 2022, 10:41 AM
Harbormaster completed remote builds in B48176: Diff 112651.Nov 5 2022, 10:41 AM
tuexen accepted this revision.Nov 5 2022, 11:34 AM
This revision is now accepted and ready to land.Nov 5 2022, 11:34 AM
rscheff updated this revision to Diff 112671.Nov 6 2022, 10:53 AM
  • add tcpi_delivered_ce for accecn and ecn (accounting received ECEs)
  • report tcpi_delivered_ce properly
This revision now requires review to proceed.Nov 6 2022, 10:53 AM
Harbormaster completed remote builds in B48185: Diff 112671.Nov 6 2022, 10:54 AM
tuexen accepted this revision.Nov 6 2022, 11:01 AM
This revision is now accepted and ready to land.Nov 6 2022, 11:01 AM
Closed by commit rG22c81cc51636: tcp: add AccECN CE packet counters to tcpinfo (authored by rscheff). · Explain WhyNov 6 2022, 11:04 AM
This revision was automatically updated to reflect the committed changes.
rscheff added a commit: rG22c81cc51636: tcp: add AccECN CE packet counters to tcpinfo.

Revision Contents
Changeset List

PathSize
sys/
netinet/
3 lines
4 lines
13 lines

Diff 112671

View Options

sys/netinet/tcp.h

Show First 20 Lines • Show All 95 Lines • ▼ Show 20 Lines
bootenv_autolist="YES" # Auto populate the list of ZFS Boot Environments bootenv_autolist="YES" # Auto populate the list of ZFS Boot Environments
#beastie_disable="NO" # Turn the beastie boot menu on and off #beastie_disable="NO" # Turn the beastie boot menu on and off
efi_max_resolution="1x1" # Set the max resolution for EFI loader to use: efi_max_resolution="1x1" # Set the max resolution for EFI loader to use:
# 480p, 720p, 1080p, 2160p/4k, 5k, or specify # 480p, 720p, 1080p, 2160p/4k, 5k, or specify
# WidthxHeight (e.g. 1920x1080) # WidthxHeight (e.g. 1920x1080)
#kernels="kernel kernel.old" # Kernels to display in the boot menu #kernels="kernel kernel.old" # Kernels to display in the boot menu
kernels_autodetect="YES" # Auto-detect kernel directories in /boot kernels_autodetect="YES" # Auto-detect kernel directories in /boot
#loader_logo="orbbw" # Desired logo: orbbw, orb, fbsdbw, beastiebw, beastie, none #loader_logo="orbbw" # Desired logo: orbbw, orb, fbsdbw, beastiebw, beastie, none
#comconsole_speed="9600" # Set the current serial console speed #comconsole_speed="115200" # Set the current serial console speed
#console="vidconsole" # A comma separated list of console(s) #console="vidconsole" # A comma separated list of console(s)
#currdev="disk1s1a" # Set the current device #currdev="disk1s1a" # Set the current device
module_path="/boot/modules;/boot/dtb;/boot/dtb/overlays" # Set the module search path module_path="/boot/modules;/boot/dtb;/boot/dtb/overlays" # Set the module search path
module_blacklist="drm drm2 radeonkms i915kms amdgpu" # Loader module blacklist module_blacklist="drm drm2 radeonkms i915kms amdgpu" # Loader module blacklist
#prompt="\\${interpret}" # Set the command prompt #prompt="\\${interpret}" # Set the command prompt
#root_disk_unit="0" # Force the root disk unit number #root_disk_unit="0" # Force the root disk unit number
#rootdev="disk1s1a" # Set the root filesystem #rootdev="disk1s1a" # Set the root filesystem
#dumpdev="disk1s1b" # Set a dump device early in the boot process #dumpdev="disk1s1b" # Set a dump device early in the boot process
▲ Show 20 Lines • Show All 67 Lines • Show Last 20 Lines
View Options

sys/netinet/tcp_ecn.c

Show First 20 Lines • Show All 95 Lines • ▼ Show 20 Lines
bootenv_autolist="YES" # Auto populate the list of ZFS Boot Environments bootenv_autolist="YES" # Auto populate the list of ZFS Boot Environments
#beastie_disable="NO" # Turn the beastie boot menu on and off #beastie_disable="NO" # Turn the beastie boot menu on and off
efi_max_resolution="1x1" # Set the max resolution for EFI loader to use: efi_max_resolution="1x1" # Set the max resolution for EFI loader to use:
# 480p, 720p, 1080p, 2160p/4k, 5k, or specify # 480p, 720p, 1080p, 2160p/4k, 5k, or specify
# WidthxHeight (e.g. 1920x1080) # WidthxHeight (e.g. 1920x1080)
#kernels="kernel kernel.old" # Kernels to display in the boot menu #kernels="kernel kernel.old" # Kernels to display in the boot menu
kernels_autodetect="YES" # Auto-detect kernel directories in /boot kernels_autodetect="YES" # Auto-detect kernel directories in /boot
#loader_logo="orbbw" # Desired logo: orbbw, orb, fbsdbw, beastiebw, beastie, none #loader_logo="orbbw" # Desired logo: orbbw, orb, fbsdbw, beastiebw, beastie, none
#comconsole_speed="9600" # Set the current serial console speed #comconsole_speed="115200" # Set the current serial console speed
#console="vidconsole" # A comma separated list of console(s) #console="vidconsole" # A comma separated list of console(s)
#currdev="disk1s1a" # Set the current device #currdev="disk1s1a" # Set the current device
module_path="/boot/modules;/boot/dtb;/boot/dtb/overlays" # Set the module search path module_path="/boot/modules;/boot/dtb;/boot/dtb/overlays" # Set the module search path
module_blacklist="drm drm2 radeonkms i915kms amdgpu" # Loader module blacklist module_blacklist="drm drm2 radeonkms i915kms amdgpu" # Loader module blacklist
#prompt="\\${interpret}" # Set the command prompt #prompt="\\${interpret}" # Set the command prompt
#root_disk_unit="0" # Force the root disk unit number #root_disk_unit="0" # Force the root disk unit number
#rootdev="disk1s1a" # Set the root filesystem #rootdev="disk1s1a" # Set the root filesystem
#dumpdev="disk1s1b" # Set a dump device early in the boot process #dumpdev="disk1s1b" # Set a dump device early in the boot process
▲ Show 20 Lines • Show All 67 Lines • Show Last 20 Lines
View Options

sys/netinet/tcp_usrreq.c

Show First 20 Lines • Show All 95 Lines • ▼ Show 20 Lines
bootenv_autolist="YES" # Auto populate the list of ZFS Boot Environments bootenv_autolist="YES" # Auto populate the list of ZFS Boot Environments
#beastie_disable="NO" # Turn the beastie boot menu on and off #beastie_disable="NO" # Turn the beastie boot menu on and off
efi_max_resolution="1x1" # Set the max resolution for EFI loader to use: efi_max_resolution="1x1" # Set the max resolution for EFI loader to use:
# 480p, 720p, 1080p, 2160p/4k, 5k, or specify # 480p, 720p, 1080p, 2160p/4k, 5k, or specify
# WidthxHeight (e.g. 1920x1080) # WidthxHeight (e.g. 1920x1080)
#kernels="kernel kernel.old" # Kernels to display in the boot menu #kernels="kernel kernel.old" # Kernels to display in the boot menu
kernels_autodetect="YES" # Auto-detect kernel directories in /boot kernels_autodetect="YES" # Auto-detect kernel directories in /boot
#loader_logo="orbbw" # Desired logo: orbbw, orb, fbsdbw, beastiebw, beastie, none #loader_logo="orbbw" # Desired logo: orbbw, orb, fbsdbw, beastiebw, beastie, none
#comconsole_speed="9600" # Set the current serial console speed #comconsole_speed="115200" # Set the current serial console speed
#console="vidconsole" # A comma separated list of console(s) #console="vidconsole" # A comma separated list of console(s)
#currdev="disk1s1a" # Set the current device #currdev="disk1s1a" # Set the current device
module_path="/boot/modules;/boot/dtb;/boot/dtb/overlays" # Set the module search path module_path="/boot/modules;/boot/dtb;/boot/dtb/overlays" # Set the module search path
module_blacklist="drm drm2 radeonkms i915kms amdgpu" # Loader module blacklist module_blacklist="drm drm2 radeonkms i915kms amdgpu" # Loader module blacklist
#prompt="\\${interpret}" # Set the command prompt #prompt="\\${interpret}" # Set the command prompt
#root_disk_unit="0" # Force the root disk unit number #root_disk_unit="0" # Force the root disk unit number
#rootdev="disk1s1a" # Set the root filesystem #rootdev="disk1s1a" # Set the root filesystem
#dumpdev="disk1s1b" # Set a dump device early in the boot process #dumpdev="disk1s1b" # Set a dump device early in the boot process
▲ Show 20 Lines • Show All 67 Lines • Show Last 20 Lines