Page MenuHomeFreeBSD
Differential D36305

arm64 pmap: batch chunk removal in pmap_remove_pages
ClosedPublic
Actions

Authored by andrew on Aug 23 2022, 10:15 AM.
Tags
None
Referenced Files
F171499021: D36305.id109705.diff
Fri, Sep 11, 12:00 PM
Unknown Object (File)
Sun, Sep 6, 1:13 PM
Unknown Object (File)
Sun, Sep 6, 10:30 AM
Unknown Object (File)
Sun, Sep 6, 2:27 AM
Unknown Object (File)
Sun, Sep 6, 2:23 AM
Unknown Object (File)
Thu, Sep 3, 5:58 PM
Unknown Object (File)
Thu, Sep 3, 1:25 PM
Unknown Object (File)
Thu, Sep 3, 1:23 PM
View All Files
Subscribers
emaste
imp

Details

Reviewers
alc
kib
markj
mjg
manu
Group Reviewers
arm64
Commits
rG92d73b0b2564: arm64 pmap: batch chunk removal in pmap_remove_pages
Summary

As with amd64 batch chunk removal in pmap_remove_pages to move it out
of the pv list lock. This is one of the main contested locks when
running poudriere on a 160 core Ampere Altra server.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 47260
Build 44147: arc lint + arc unit

Event Timeline

andrew created this revision.Aug 23 2022, 10:15 AM
Herald added a reviewer: manu. · View Herald TranscriptAug 23 2022, 10:15 AM
Herald added subscribers: emaste, imp. · View Herald Transcript
andrew requested review of this revision.Aug 23 2022, 10:15 AM
Harbormaster completed remote builds in B47069: Diff 109705.Aug 23 2022, 10:15 AM
markj added inline comments.Aug 29 2022, 3:05 PM
sys/arm64/arm64/pmap.c
2755

Missing newline.

5419

Do pv chunks need to be freed under the pmap lock?

andrew added inline comments.Aug 31 2022, 11:18 AM
sys/arm64/arm64/pmap.c
5419

It's the same as amd64. If the comments in D21832 don't apply here I can move it.

alc added inline comments.Aug 31 2022, 4:54 PM
sys/arm64/arm64/pmap.c
5419

No, don't move it. The same reason applies here.

andrew updated this revision to Diff 110209.Sep 6 2022, 12:24 PM

Add a missing newline

Harbormaster completed remote builds in B47260: Diff 110209.Sep 6 2022, 12:24 PM
This revision was not accepted when it landed; it landed in state Needs Review.Sep 27 2022, 3:15 PM
Closed by commit rG92d73b0b2564: arm64 pmap: batch chunk removal in pmap_remove_pages (authored by andrew). · Explain Why
This revision was automatically updated to reflect the committed changes.
andrew added a commit: rG92d73b0b2564: arm64 pmap: batch chunk removal in pmap_remove_pages.

Revision Contents
Changeset List

PathSize
sys/
arm64/
arm64/
41 lines

Diff 110209

View Options

sys/arm64/arm64/pmap.c

Loading...