Page MenuHomeFreeBSD
Differential D36271

bhyve virtio-scsi: Avoid out of bounds accesses to guest requests.
ClosedPublic
Actions

Authored by jhb on Aug 19 2022, 11:42 PM.
Tags
None
Referenced Files
F137821981: D36271.id109578.diff
Wed, Nov 26, 3:37 AM
F137821978: D36271.id109578.diff
Wed, Nov 26, 3:37 AM
F137821974: D36271.id109578.diff
Wed, Nov 26, 3:37 AM
Unknown Object (File)
Wed, Nov 19, 1:48 PM
Unknown Object (File)
Fri, Nov 14, 5:53 AM
Unknown Object (File)
Fri, Oct 31, 1:31 PM
Unknown Object (File)
Oct 13 2025, 2:45 AM
Unknown Object (File)
Oct 13 2025, 2:45 AM
View All 91 Files
Subscribers
bcran
emaste
freqlabs
imp
rgrimes

Details

Reviewers
mav
emaste
Group Reviewers
bhyve
Commits
rG1282bf40f7b9: bhyve virtio-scsi: Avoid out of bounds accesses to guest requests.
rGb37b564ecf0a: bhyve virtio-scsi: Avoid out of bounds accesses to guest requests.
rGbb31aee26bd1: bhyve virtio-scsi: Avoid out of bounds accesses to guest requests.
Summary
  • Ignore I/O requests with insufficiently sized input or output buffers (those not containing compete request headers).
  • Ignore control requests with improperly sized buffers.
  • While here, explicitly zero the output header of an I/O request to avoid leaking malloc garbage from the host if the header is not fully populated.

PR: 264521
Reported by: Robert Morris <rtm@lcs.mit.edu>
Sponsored by: The FreeBSD Foundation

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 47029
Build 43918: arc lint + arc unit

Event Timeline

jhb created this revision.Aug 19 2022, 11:42 PM
Herald added a reviewer: bhyve. · View Herald TranscriptAug 19 2022, 11:42 PM
Herald added subscribers: bcran, rgrimes, imp. · View Herald Transcript
jhb requested review of this revision.Aug 19 2022, 11:42 PM
Harbormaster completed remote builds in B47029: Diff 109578.Aug 19 2022, 11:42 PM
jhb added a parent revision: D36270: bhyve virtio-scsi: Tidy warning and debug prints..Aug 19 2022, 11:42 PM
jhb added a comment.Aug 19 2022, 11:44 PM

I have only compiled this, I have not run-tested it as I don't have a virtio-scsi setup handy.

mav accepted this revision.Aug 20 2022, 9:03 PM

Looks good to me with one comment.

usr.sbin/bhyve/pci_virtio_scsi.c
375

I wonder whether we should be more relaxed here with < ? Can the structure grow in later versions?

This revision is now accepted and ready to land.Aug 20 2022, 9:03 PM
emaste added inline comments.Aug 29 2022, 12:59 AM
usr.sbin/bhyve/pci_virtio_scsi.c
375

There isn't a version in the struct, so I think this is a safe choice. We can always change this if and when we learn about a new/larger struct.

jhb added inline comments.Aug 29 2022, 5:18 PM
usr.sbin/bhyve/pci_virtio_scsi.c
375

The current 1.1 spec says the payload of both of these commands is a fixed size. I agree that we can relax this in the future if needed.

emaste accepted this revision.Aug 29 2022, 5:44 PM
Closed by commit rGbb31aee26bd1: bhyve virtio-scsi: Avoid out of bounds accesses to guest requests. (authored by jhb). · Explain WhyAug 29 2022, 10:39 PM
This revision was automatically updated to reflect the committed changes.
jhb added a commit: rGbb31aee26bd1: bhyve virtio-scsi: Avoid out of bounds accesses to guest requests..
jhb added a commit: rGb37b564ecf0a: bhyve virtio-scsi: Avoid out of bounds accesses to guest requests..Nov 11 2022, 1:24 AM
jhb added a commit: rG1282bf40f7b9: bhyve virtio-scsi: Avoid out of bounds accesses to guest requests..

Revision Contents
Changeset List

PathSize
usr.sbin/
bhyve/
24 lines

Diff 109578

View Options

usr.sbin/bhyve/pci_virtio_scsi.c

Loading...