stand: Change disk_fmtdev to take a struct devdesc *
ClosedPublic
Actions

Authored by imp on Jul 25 2022, 8:32 PM.

Details

Reviewers

tsoome
kevans
manu

Commits

rG9dee581ad980: stand: Change disk_fmtdev to take a struct devdesc *
rGc32dde316692: stand: Change disk_fmtdev to take a struct devdesc *

Summary

We do a number of games with ploymorphism for different types struct
*devdesc. Change the parameter to take a struct devdesc * to match other
dv_devfmt functions in the system.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

imp created this revision.Jul 25 2022, 8:32 PM

Herald added a reviewer: manu. · View Herald TranscriptJul 25 2022, 8:32 PM

Herald added a subscriber: dab. · View Herald Transcript

Harbormaster completed remote builds in B46559: Diff 108510.Jul 25 2022, 8:32 PM

imp requested review of this revision.Jul 25 2022, 8:32 PM

imp added a parent revision: D35913: stand: Make sure nobody has a NULL pointer for dv_cleanup.

imp added a child revision: D35915: stand: Add dv_devfmt to return a string represenation of the device.

tsoome added inline comments.Jul 25 2022, 9:49 PM

stand/common/disk.h
118–119	I know it is a bit like documenting, but other prototypes just do show the type.

imp retitled this revision from stand: Change disk_fmtdev to take a void * to stand: Change disk_fmtdev to take a struct devdesc *.Jul 28 2022, 4:54 PM

imp edited the summary of this revision. (Show Details)

rework to take devdesc instead to match dv_devfmt

Harbormaster completed remote builds in B46644: Diff 108651.Jul 28 2022, 4:57 PM

This revision was not accepted when it landed; it landed in state Needs Review.Aug 11 2022, 4:28 PM

Closed by commit rGc32dde316692: stand: Change disk_fmtdev to take a struct devdesc * (authored by imp). · Explain Why

This revision was automatically updated to reflect the committed changes.

imp added a commit: rGc32dde316692: stand: Change disk_fmtdev to take a struct devdesc *.

imp added a commit: rG9dee581ad980: stand: Change disk_fmtdev to take a struct devdesc *.Jan 24 2023, 10:16 PM