Differential D35640

unix: change error code for recvmsg() failed due to RLIMIT_NOFILE
ClosedPublic
Actions

Authored by glebius on Jun 28 2022, 9:32 PM.

Tags

None

Referenced Files

	F163256258: D35640.id107559.diff
	Tue, Jul 21, 11:54 AM

	F163249575: D35640.id107502.diff
	Tue, Jul 21, 10:13 AM

	F163245684: D35640.id.diff
	Tue, Jul 21, 9:22 AM

	Unknown Object (File)
	Sun, Jul 19, 8:24 PM

	Unknown Object (File)
	Sat, Jul 18, 4:11 PM

	Unknown Object (File)
	Sat, Jul 18, 3:52 AM

	Unknown Object (File)
	Sat, Jul 11, 2:18 AM

	Unknown Object (File)
	Wed, Jul 8, 10:19 AM

Subscribers

Details

Reviewers

Group Reviewers

network
manpages

Commits

rG48a55bbfe95b: unix: change error code for recvmsg() failed due to RLIMIT_NOFILE

Summary

Instead of returning EMSGSIZE pass the error code from fdallocn() directly
to userland. That would be EMFILE, which makes much more sense. This
error code is not listed in the specification[1], but the specification
doesn't cover such edge case at all. Meanwhile the specification lists
EMSGSIZE as the error code for invalid value of msg_iovlen, and FreeBSD
follows that, see sys_recmsg(). Differentiating these two cases will make
a developer/admin life much easier when debugging.

[1] https://pubs.opengroup.org/onlinepubs/9699919799/functions/recvmsg.html

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

glebius created this revision.Jun 28 2022, 9:32 PM

Herald added a reviewer: manpages. · View Herald TranscriptJun 28 2022, 9:32 PM

Herald added a subscriber: imp. · View Herald Transcript

glebius requested review of this revision.Jun 28 2022, 9:32 PM

Harbormaster completed remote builds in B46163: Diff 107502.Jun 28 2022, 9:32 PM

glebius added a reviewer: markj.Jun 28 2022, 9:32 PM

markj accepted this revision as: markj.Jun 29 2022, 2:03 PM

markj added inline comments.

lib/libc/sys/recv.2
344
346
353

This revision is now accepted and ready to land.Jun 29 2022, 2:03 PM

Closed by commit rG48a55bbfe95b: unix: change error code for recvmsg() failed due to RLIMIT_NOFILE (authored by glebius). · Explain WhyJun 29 2022, 4:43 PM

This revision was automatically updated to reflect the committed changes.

glebius marked 3 inline comments as done.

glebius added a commit: rG48a55bbfe95b: unix: change error code for recvmsg() failed due to RLIMIT_NOFILE.

Revision Contents
Changeset List

Path

Size

lib/

libc/

sys/

19 lines

sys/

kern/

3 lines

tests/

sys/

kern/

unix_passfd_test.c

4 lines

Diff 107559

lib/libc/sys/recv.2

Loading...

sys/kern/uipc_usrreq.c

Loading...

tests/sys/kern/unix_passfd_test.c

Loading...