Page MenuHomeFreeBSD
Differential D34691

Port subr_physmem to userspace and add tests
ClosedPublic
Actions

Authored by andrew on Mar 28 2022, 11:14 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 19, 3:47 AM
Unknown Object (File)
Mar 14 2024, 3:57 AM
Unknown Object (File)
Mar 3 2024, 1:00 AM
Unknown Object (File)
Mar 3 2024, 1:00 AM
Unknown Object (File)
Mar 2 2024, 2:16 PM
Unknown Object (File)
Mar 2 2024, 2:04 PM
Unknown Object (File)
Dec 27 2023, 8:04 AM
Unknown Object (File)
Dec 24 2023, 10:48 PM
View All 30 Files
Subscribers
emaste
imp
rstone

Details

Reviewers
emaste
Group Reviewers
ARM
arm64
riscv
Commits
rG0edb26c3bad0: Port subr_physmem to userspace and add tests
rG8c99dfed5412: Port subr_physmem to userspace and add tests
Summary

These give us some confidience we haven't broken anything in early
boot code that may be running before the console.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 44901
Build 41789: arc lint + arc unit

Event Timeline

andrew created this revision.Mar 28 2022, 11:14 AM
Herald added a subscriber: imp. · View Herald TranscriptMar 28 2022, 11:14 AM
andrew requested review of this revision.Mar 28 2022, 11:14 AM
Harbormaster completed remote builds in B44901: Diff 104278.Mar 28 2022, 11:14 AM
emaste added a subscriber: rstone.Mar 28 2022, 3:02 PM
emaste accepted this revision.Mar 28 2022, 3:04 PM
emaste added a subscriber: emaste.

I think this is good, modulo discussion about more comprehensive/general kernel unit test support.

tests/sys/kern/subr_physmem_test.c
2

bump year?

This revision is now accepted and ready to land.Mar 28 2022, 3:04 PM
andrew added a child revision: D34694: Handle non-page aligned/sized memory in physmem.Mar 28 2022, 3:05 PM
imp added inline comments.Mar 28 2022, 10:24 PM
tests/sys/kern/subr_physmem_test.c
3

Do we need the 'All Rights Reserved' too?

emaste added inline comments.Mar 29 2022, 12:39 AM
tests/sys/kern/subr_physmem_test.c
3

No, "All Rights Reserved." is not required on new FreeBSD Foundation copyrights and can be removed from any existing ones.

Closed by commit rG8c99dfed5412: Port subr_physmem to userspace and add tests (authored by andrew). · Explain WhyApr 6 2022, 1:25 PM
This revision was automatically updated to reflect the committed changes.
andrew added a commit: rG8c99dfed5412: Port subr_physmem to userspace and add tests.
andrew added a commit: rG0edb26c3bad0: Port subr_physmem to userspace and add tests.May 3 2022, 2:05 PM
ehem_freebsd_m5p.com mentioned this in D32343: physmem: add ram0 pseudo-driver.May 7 2022, 4:08 AM

Revision Contents
Changeset List

PathSize
sys/
kern/
25 lines
tests/
sys/
kern/
4 lines
122 lines

Diff 104278

View Options

sys/kern/subr_physmem.c

Loading...
View Options

tests/sys/kern/Makefile

Loading...
View Options

tests/sys/kern/subr_physmem_test.c

Loading...