LinuxKPI: Use negative bit field size to trigger BUILD_BUG_ON_ZERO
ClosedPublic
Actions

Authored by wulf on Dec 27 2021, 11:02 PM.

Details

Reviewers

• hselasky
manu

Commits

rGef743744f0f4: LinuxKPI: Use negative bit field size to trigger BUILD_BUG_ON_ZERO
rG64dab63f3b3b: LinuxKPI: Use negative bit field size to trigger BUILD_BUG_ON_ZERO

Summary

compile time assertion on non-NULL pointers. Tests conducted show that
_Static_assert, negative array size method and current code does not
handle pointers well enough. Bit field method solves this problem.

This change is derrived from Linux implementation of BUILD_BUG_ON_ZERO.

MFC after: 1 week

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

wulf created this revision.Dec 27 2021, 11:02 PM

Herald added subscribers: linuxkpi, emaste, imp. · View Herald TranscriptDec 27 2021, 11:02 PM

wulf requested review of this revision.Dec 27 2021, 11:02 PM

Harbormaster completed remote builds in B43618: Diff 100631.Dec 27 2021, 11:03 PM

This revision was not accepted when it landed; it landed in state Needs Review.Jan 10 2022, 7:52 PM

Closed by commit rG64dab63f3b3b: LinuxKPI: Use negative bit field size to trigger BUILD_BUG_ON_ZERO (authored by wulf). · Explain Why

This revision was automatically updated to reflect the committed changes.

wulf added a commit: rG64dab63f3b3b: LinuxKPI: Use negative bit field size to trigger BUILD_BUG_ON_ZERO.

wulf added a commit: rGef743744f0f4: LinuxKPI: Use negative bit field size to trigger BUILD_BUG_ON_ZERO.Jan 22 2022, 7:40 PM

Revision Contents
Changeset List

Path

Size

sys/

compat/

linuxkpi/

common/

include/

linux/

kernel.h

4 lines

Diff 101239

View Options

sys/compat/linuxkpi/common/include/linux/kernel.h

LinuxKPI: Use negative bit field size to trigger BUILD_BUG_ON_ZEROClosedPublicActions