Page MenuHomeFreeBSD
Differential D33717

route: remove write-only struct hostent from getaddr()
ClosedPublic
Actions

Authored by emaste on Jan 2 2022, 12:18 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jan 2, 9:30 PM
Unknown Object (File)
Thu, Dec 19, 6:36 PM
Unknown Object (File)
Dec 11 2024, 12:51 PM
Unknown Object (File)
Dec 5 2024, 4:18 PM
Unknown Object (File)
Dec 3 2024, 9:11 PM
Unknown Object (File)
Dec 1 2024, 2:44 PM
Unknown Object (File)
Dec 1 2024, 1:31 PM
Unknown Object (File)
Nov 28 2024, 5:44 PM
View All 86 Files
Subscribers
brooks

Details

Reviewers
melifaro
imp
hrs
Commits
rGe5bcc6a85677: route: remove write-only struct hostent from getaddr()
rGf567fcb2ffc4: route: remove write-only struct hostent from getaddr()

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

emaste requested review of this revision.Jan 2 2022, 12:18 AM
emaste created this revision.
emaste updated this revision to Diff 100815.Jan 2 2022, 12:20 AM
emaste added reviewers: melifaro, imp, hrs.
emaste added a subscriber: freebsd-net-list.
emaste mentioned this in D33710: route: silence Clang set but not used warning under WITHOUT_INET.Jan 2 2022, 1:33 AM
emaste removed reviewers: imp, hrs.
emaste added reviewers: imp, hrs.
emaste updated this revision to Diff 100973.Jan 5 2022, 2:47 PM

remove now-unused variable

emaste added a comment.Jan 5 2022, 2:52 PM

As @melifaro pointed out to prompt this change hp was passed to three getaddr() calls in newroute(), and was not otherwise used, and getaddr() does not use the passed-in value.

emaste added a subscriber: brooks.Jan 5 2022, 3:00 PM
emaste removed a subscriber: freebsd-net-list.Jan 5 2022, 3:07 PM
melifaro accepted this revision.Jan 5 2022, 5:03 PM
This revision is now accepted and ready to land.Jan 5 2022, 5:03 PM
Closed by commit rGf567fcb2ffc4: route: remove write-only struct hostent from getaddr() (authored by emaste). · Explain WhyJan 6 2022, 3:51 PM
This revision was automatically updated to reflect the committed changes.
emaste added a commit: rGf567fcb2ffc4: route: remove write-only struct hostent from getaddr().
emaste added a commit: rGe5bcc6a85677: route: remove write-only struct hostent from getaddr().Jan 27 2022, 12:37 AM

Revision Contents
Changeset List

PathSize
sbin/
route/
33 lines

Diff 101055

View Options

sbin/route/route.c

Loading...