Fix if_ntb interface setup to include IFF_MULTICAST. This allows IPv6 link local addresses (and other IPv6 functionality) to work.
ClosedPublic
Actions

Authored by dab on Jun 17 2016, 7:45 PM.

Details

Reviewers

cem
vangyzen
mav

Commits

rP417968: devel/qca: Fix building without SSLv3 and SHA-0
rS302014: Fix if_ntb interface setup to include IFF_MULTICAST.

Summary

See PR 210355

Credit for patch goes to Steve Wahl, Dell Compellent.

Test Plan

Tested locally at Dell Compellent. Before the change no link local address was configured on the interface and after manually configuring an IPv6 address on the interface ping6 failed. After this change, a link local address was configured and ping6 succeeded.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dab updated this revision to Diff 17672.Jun 17 2016, 7:45 PM

dab retitled this revision from to Fix if_ntb interface setup to include IFF_MULTICAST. This allows IPv6 link local addresses (and other IPv6 functionality) to work..

dab updated this object.

dab edited the test plan for this revision. (Show Details)

dab added a reviewer: vangyzen.

Herald added a reviewer: cem. · View Herald TranscriptJun 17 2016, 7:45 PM

Herald added a subscriber: imp. · View Herald Transcript

dab updated this object.Jun 17 2016, 7:47 PM

dab edited edge metadata.

FYI, mav@ is also a good person for if_ntb/ntb_hw reviews.

cem accepted this revision.Jun 17 2016, 7:48 PM

cem edited edge metadata.

This revision is now accepted and ready to land.Jun 17 2016, 7:48 PM

Conrad: Can you test this with an Intel NTB, just to make sure nothing blows up? We can only test with non-Intel hardware and an in-house driver.

dab edited the test plan for this revision. (Show Details)Jun 17 2016, 7:49 PM

dab removed a reviewer: mav.

In D6885#144446, @vangyzen wrote:

Conrad: Can you test this with an Intel NTB, just to make sure nothing blows up? We can only test with non-Intel hardware and an in-house driver.

I don't have a test rig set up where loading if_ntb is easy (we're just using ntb_hw, not if_ntb, and our module on top of ntb_hw conflicts with if_ntb). And I'm offline through Sunday. Mav may be able to test sooner.