Page MenuHomeFreeBSD

Fix if_ntb interface setup to include IFF_MULTICAST. This allows IPv6 link local addresses (and other IPv6 functionality) to work.
ClosedPublic

Authored by dab on Jun 17 2016, 7:45 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 5, 4:32 AM
Unknown Object (File)
Sun, Dec 1, 7:16 PM
Unknown Object (File)
Thu, Nov 28, 11:15 PM
Unknown Object (File)
Nov 22 2024, 5:52 AM
Unknown Object (File)
Nov 22 2024, 3:12 AM
Unknown Object (File)
Nov 9 2024, 6:28 AM
Unknown Object (File)
Oct 1 2024, 5:54 PM
Unknown Object (File)
Oct 1 2024, 4:42 PM
Subscribers

Details

Summary

See PR 210355

Credit for patch goes to Steve Wahl, Dell Compellent.

Test Plan

Tested locally at Dell Compellent. Before the change no link local address was configured on the interface and after manually configuring an IPv6 address on the interface ping6 failed. After this change, a link local address was configured and ping6 succeeded.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4263
Build 4307: arc lint + arc unit

Event Timeline

dab retitled this revision from to Fix if_ntb interface setup to include IFF_MULTICAST. This allows IPv6 link local addresses (and other IPv6 functionality) to work..
dab updated this object.
dab edited the test plan for this revision. (Show Details)
dab added a reviewer: vangyzen.
dab edited edge metadata.

FYI, mav@ is also a good person for if_ntb/ntb_hw reviews.

cem edited edge metadata.
This revision is now accepted and ready to land.Jun 17 2016, 7:48 PM
vangyzen edited edge metadata.

Conrad: Can you test this with an Intel NTB, just to make sure nothing blows up? We can only test with non-Intel hardware and an in-house driver.

dab removed a reviewer: mav.

Conrad: Can you test this with an Intel NTB, just to make sure nothing blows up? We can only test with non-Intel hardware and an in-house driver.

I don't have a test rig set up where loading if_ntb is easy (we're just using ntb_hw, not if_ntb, and our module on top of ntb_hw conflicts with if_ntb). And I'm offline through Sunday. Mav may be able to test sooner.

David, did you remove mav@ on accident?

In D6885#144452, @cem wrote:

David, did you remove mav@ on accident?

I must have. I was updating to document what I did to test. Perhaps I overwrote your revised reviewer list at the same time?

Sorry about that.

mav edited edge metadata.

I've reproduced David's IPv6 experiment on Intel Xeon v4 hardware. Patch indeed fixes the issue.

This revision was automatically updated to reflect the committed changes.