Page MenuHomeFreeBSD
Differential D6780

loader.efi try to fallback on first device
ClosedPublic
Actions

Authored by manu on Jun 9 2016, 12:24 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 20, 5:55 PM
Unknown Object (File)
Thu, Dec 12, 7:13 AM
Unknown Object (File)
Thu, Dec 12, 12:54 AM
Unknown Object (File)
Wed, Dec 4, 10:03 AM
Unknown Object (File)
Wed, Dec 4, 10:03 AM
Unknown Object (File)
Wed, Dec 4, 10:03 AM
Unknown Object (File)
Wed, Dec 4, 10:03 AM
Unknown Object (File)
Wed, Dec 4, 9:41 AM
View All 78 Files
Subscribers
allanjude
cem
imp
Contributor Reviews (src)

Details

Reviewers
emaste
jhb
allanjude
andrew
imp
smh
Commits
rS308125: In loader.efi, instead of exiting directly, try to fallback on the
Summary

Try to fallback on the first device if we can't find the device from which the image is loaded.

Test Plan

Tested on beaglebone black with u-boot efi implementation.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

manu updated this revision to Diff 17444.Jun 9 2016, 12:24 AM
manu retitled this revision from to loader.efi try to fallback on first device.
manu updated this object.
manu edited the test plan for this revision. (Show Details)
manu set the repository for this revision to rS FreeBSD src repository - subversion.
manu added a project: ARM.
Herald added subscribers: Contributor Reviews (src), imp. · View Herald TranscriptJun 9 2016, 12:24 AM
cem added a subscriber: cem.Jun 9 2016, 12:30 AM
manu added a reviewer: andrew.Jun 9 2016, 12:30 AM
manu removed a project: ARM.
andrew added reviewers: emaste, smh, imp, jhb.Jun 9 2016, 12:41 AM
allanjude accepted this revision.Jun 14 2016, 1:19 AM
allanjude added a reviewer: allanjude.
allanjude added a subscriber: allanjude.

goatforit

This revision is now accepted and ready to land.Jun 14 2016, 1:19 AM
smh edited edge metadata.Jun 14 2016, 2:50 AM

I'd like to know why finding the current device would ever fail?

manu added a comment.Jun 15 2016, 2:46 AM
In D6780#143556, @smh wrote:

I'd like to know why finding the current device would ever fail?

I see at least two valid reason :

  1. In case of a bad/incomplete EFI implementation (like U-Boot currently)
  2. In embedded world you could have uboot + loader.efi in a SPI flash for example and this device would not be exposed as an EFI disk.
jhb edited edge metadata.Jun 15 2016, 5:04 PM

I would rather put this logic in find_currdev() itself.

emaste edited edge metadata.Oct 20 2016, 9:00 PM

Should we go with @jhb's suggestion then?

imp accepted this revision.Oct 20 2016, 9:49 PM
imp edited edge metadata.

I'm good either way, though jhb's method is cleaner.

manu added a comment.Oct 21 2016, 9:38 AM

Totally forgot about this review, I'll update it this weekend with @jhb suggestion.

manu updated this revision to Diff 21739.Oct 27 2016, 5:05 PM
manu edited edge metadata.

Update with @jhb suggestion.

This revision now requires review to proceed.Oct 27 2016, 5:05 PM
jhb accepted this revision.Oct 27 2016, 9:23 PM
jhb edited edge metadata.

Thanks

This revision is now accepted and ready to land.Oct 27 2016, 9:23 PM
Closed by commit rS308125: In loader.efi, instead of exiting directly, try to fallback on the (authored by manu). · Explain WhyOct 31 2016, 11:30 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
sys/
boot/
efi/
loader/
5 lines

Diff 21739

View Options

sys/boot/efi/loader/main.c

Loading...