The QoS core expects the total length of the packet in the low bits of
TDES3. Linux and U-Boot both fill it in, but txdesc_setup() only wrote
the flags there. Pass the length of the whole packet down and write it
to every descriptor of the packet.
Details
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Skipped - Unit
Tests Skipped - Build Status
Buildable 78548 Build 75431: arc lint + arc unit
Event Timeline
| sys/dev/dwc/dwc4_dma.c | ||
|---|---|---|
| 114–115 | Actually, it looks like this entire packet-length field is reserved when TSE is not used ? | |
| sys/dev/dwc/dwc4_dma.c | ||
|---|---|---|
| 115 | ||
Thanks for the review.
Looking at the RK3568 TRM (section 20.6.3, TDES3 read format): bits [14:0] are FL/TPL,
the length of the packet when TSE is not set,
but "when DWRR/WFQ algorithm is NOT enabled,
value written into this field is not used when TSE = 0".
The driver uses a single TX queue and does not select a scheduling algorithm,
so the hardware never looks at the value and this change has no effect.
Linux and U-Boot do write it, but there is nothing to gain here, so I am dropping the
commit for now and will bring it back if DWRR/WFQ or TSO gets enabled.
You were right that the two macros are the TSE and non-TSE forms of the
same field and that bit 15 is reserved without TSE.