ktls: Fix capability checks in ktls_reset_receive_tag()
ClosedPublic
Actions

Authored by olivier on Thu, Oct 15, 7:51 PM.

Details

Reviewers

gallatin
markj
jhb
kib
glebius

Commits

rG32a981471c01: ktls: Fix capability checks in ktls_reset_receive_tag()

Summary

IFCAP2_RXTLS4 and IFCAP2_RXTLS6 are bit numbers, not masks, so
ktls_reset_receive_tag() tested if_capenable2 against 0 for IPv4 and
against the RXTLS4 bit for IPv6. An IPv4 connection with NIC receive
TLS offload thus never got a new receive tag after its packets moved
to another interface, and fell back to software decryption for good.
c721694 fixed the same checks in ktls_alloc_rcv_tag(); use
IFCAP2_BIT() here as well.

Found with CBMC.

Fixes: fe8c78f ("ktls: Add full support for TLS RX offloading via network interface.")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

olivier requested review of this revision.Thu, Oct 15, 7:51 PM

olivier created this revision.

olivier added a reviewer: jhb.

gallatin added a reviewer: kib.Thu, Oct 15, 9:59 PM

gallatin added a reviewer: glebius.Thu, Oct 15, 10:01 PM

@kib The more errors like this that I see, the more firmly convinced I am that ifcap2 was a mistake, and that we should just have just extended if_capabilities / if_capenable to 64-bits.

This revision is now accepted and ready to land.Thu, Oct 15, 10:04 PM

kib accepted this revision.Fri, Oct 16, 2:28 AM

Closed by commit rG32a981471c01: ktls: Fix capability checks in ktls_reset_receive_tag() (authored by olivier). · Explain WhyFri, Oct 16, 4:46 AM

This revision was automatically updated to reflect the committed changes.

olivier added a commit: rG32a981471c01: ktls: Fix capability checks in ktls_reset_receive_tag().

Herald added subscribers: olce, imp. · View Herald TranscriptFri, Oct 16, 4:46 AM