Page MenuHomeFreeBSD
Differential D5853

dhclient: Log a warning instead of bailing upon "illegal" options
ClosedPublic
Actions

Authored by sepherosa_gmail.com on Apr 6 2016, 6:50 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 25, 11:38 PM
Unknown Object (File)
Thu, Apr 25, 11:35 PM
Unknown Object (File)
Feb 28 2024, 7:14 AM
Unknown Object (File)
Dec 23 2023, 10:24 AM
Unknown Object (File)
Dec 20 2023, 12:44 AM
Unknown Object (File)
Dec 5 2023, 7:39 PM
Unknown Object (File)
Nov 23 2023, 11:11 AM
Unknown Object (File)
Nov 10 2023, 9:32 AM
View All 55 Files
Subscribers
sbruno

Details

Reviewers
howard0su_gmail.com
honzhan_microsoft.com
pkelsey
decui_microsoft.com
freebsd-net-list
jhb
delphij
glebius
gnn
adrian
Group Reviewers
network
secteam
Commits
rS299156: MFC r298385
rS298385: dhclient: Log a warning instead of bailing upon "illegal" options
Summary

In Azure, the DHCP servers add private option (id 0xf5), which contains binary form of an IPv4 address. Once this option is converted to string form, it could contain '$', e.g.

IPv4 address: 100.72.36.54
binary form: 0x64 0x48 0x24 0x36
string form: "dH$6"

dhclient bails upon "illegal" options like the above example, thus the VM bring-up will fail.

Also as a side note, this "illegal" option detection was added in OpenBSD ~11years ago:
http://cvsweb.openbsd.org/cgi-bin/cvsweb/src/sbin/dhclient/dhclient.c?rev=1.50&content-type=text/x-cvsweb-markup

And it was removed along with the removal of script support in OpenBSD ~3years ago:
http://cvsweb.openbsd.org/cgi-bin/cvsweb/src/sbin/dhclient/dhclient.c?rev=1.159&content-type=text/x-cvsweb-markup

Noticed by: Hongxiong Xian <v-hoxian microsoft com>
Tested by: Hongxiong Xian <v-hoxian microsoft com>
Analyzed by: Dong Liu <doliu microsoft com>

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

sepherosa_gmail.com updated this revision to Diff 14915.Apr 6 2016, 6:50 AM
sepherosa_gmail.com retitled this revision from to dhclient: Log a warning instead of bailing upon "illegal" options.
sepherosa_gmail.com updated this object.
sepherosa_gmail.com edited the test plan for this revision. (Show Details)
sepherosa_gmail.com added reviewers: network, secteam, delphij, glebius, adrian, decui_microsoft.com, honzhan_microsoft.com, howard0su_gmail.com.
decui_microsoft.com accepted this revision.Apr 6 2016, 7:01 AM
decui_microsoft.com edited edge metadata.
This revision is now accepted and ready to land.Apr 6 2016, 7:01 AM
sepherosa_gmail.com added a reviewer: freebsd-net-list.Apr 11 2016, 7:41 AM
sepherosa_gmail.com added a comment.Apr 15 2016, 8:03 AM

If no objection comes, it will be committed in the middle of next week.

sbruno added reviewers: pkelsey, jhb, gnn.Apr 18 2016, 3:36 PM
sbruno added a subscriber: sbruno.

spam a few more reviewers who have poked at dhclient in the past.

jhb accepted this revision.Apr 18 2016, 6:42 PM
jhb edited edge metadata.
Closed by commit rS298385: dhclient: Log a warning instead of bailing upon "illegal" options (authored by sephe). · Explain WhyApr 20 2016, 11:56 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sbin/
dhclient/
21 lines

Diff 15413

View Options

head/sbin/dhclient/dhclient.c

Loading...