Page MenuHomeFreeBSD
Differential D58293

bhyve: check upper bounds for value from qsz
ClosedPublic
Actions

Authored by tsoome on Fri, Jul 17, 8:14 AM.
Tags
None
Referenced Files
F163555997: D58293.id182354.diff
Fri, Jul 24, 11:06 AM
F163551403: D58293.diff
Fri, Jul 24, 9:45 AM
F163541243: D58293.id182218.diff
Fri, Jul 24, 7:19 AM
F163540872: D58293.id182218.diff
Fri, Jul 24, 7:14 AM
F163533491: D58293.id182354.diff
Fri, Jul 24, 5:28 AM
F163521371: D58293.diff
Fri, Jul 24, 2:18 AM
F163510735: D58293.id182107.diff
Thu, Jul 23, 11:30 PM
F163510482: D58293.id182107.diff
Thu, Jul 23, 11:26 PM
View All 22 Files
Subscribers
bcran
bnovkov
chuck
dab
imp
rgrimes

Details

Reviewers
chuck
Group Reviewers
bhyve
Commits
rGa0486017c2a4: bhyve: check upper bounds for value from qsz
Summary

The max_qentries in pci_nvme_softc is uint16_t and
too large int may get truncated to invalid value.
While there, use local declarations for val.

Suggested by: Bill Sommerfeld

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tsoome created this revision.Fri, Jul 17, 8:14 AM
Herald added a reviewer: bhyve. · View Herald TranscriptFri, Jul 17, 8:14 AM
Herald added subscribers: dab, bcran, rgrimes, imp. · View Herald Transcript
tsoome requested review of this revision.Fri, Jul 17, 8:14 AM
Harbormaster completed remote builds in B74864: Diff 182107.Fri, Jul 17, 8:14 AM
bnovkov added a subscriber: bnovkov.Fri, Jul 17, 2:43 PM
bnovkov added inline comments.
usr.sbin/bhyve/pci_nvme.c
3188

Why aren't we defining val at the start of the function anymore?

chuck accepted this revision as: chuck.Sat, Jul 18, 10:26 PM
chuck added a subscriber: chuck.

Assuming you restore the declaration of val as @bnovkov suggested, LGTM.

This revision is now accepted and ready to land.Sat, Jul 18, 10:26 PM
tsoome updated this revision to Diff 182218.Sun, Jul 19, 1:27 PM

declare val at the beginning of function.

This revision now requires review to proceed.Sun, Jul 19, 1:27 PM
Harbormaster completed remote builds in B74928: Diff 182218.Sun, Jul 19, 1:27 PM
tsoome marked an inline comment as done.Sun, Jul 19, 1:27 PM
chuck accepted this revision as: chuck.Sun, Jul 19, 3:38 PM
This revision is now accepted and ready to land.Sun, Jul 19, 3:38 PM
Closed by commit rGa0486017c2a4: bhyve: check upper bounds for value from qsz (authored by tsoome). · Explain WhyTue, Jul 21, 7:08 AM
This revision was automatically updated to reflect the committed changes.
tsoome added a commit: rGa0486017c2a4: bhyve: check upper bounds for value from qsz.

Revision Contents
Changeset List

PathSize
usr.sbin/
bhyve/
2 lines

Diff 182354

View Options

usr.sbin/bhyve/pci_nvme.c

Loading...