Page MenuHomeFreeBSD

Support for LINUX_TCGETS2 and LINUX_TCSETS2 ioctls
Needs ReviewPublic

Authored by brianfundakowskifeldman_gmail.com on Tue, Jul 14, 12:58 PM.
Referenced Files
F162798342: D58224.diff
Fri, Jul 17, 12:42 AM
F162791510: D58224.diff
Thu, Jul 16, 10:45 PM
Unknown Object (File)
Thu, Jul 16, 7:44 PM
Unknown Object (File)
Thu, Jul 16, 12:50 PM
Unknown Object (File)
Tue, Jul 14, 4:14 PM
Subscribers
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None
Summary

In order to support the new Grok command-line application under Linuxulator, we must add support for Linux's more recent terminal control ioctl interface which breaks speed out into fields directly. This is a quick and dirty proof of concept to show that the functionality allows Grok to run, whereas I believe the proper implementation ought to be the introduction of a new union within linux_ioctl.h to overlay the various linux_term* structs and not adding a separate bsd_to_linux_termios2 function which is largely identical to the one for linux_termios.

Edit: Now I feel rather silly seeing that it is present in HEAD and merely not backported. https://github.com/freebsd/freebsd-src/pull/1949

Test Plan

curl -fsSL https://x.ai/cli/install.sh | bash

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped