Page MenuHomeFreeBSD

kern: syscall_thread_enter() cannot fail
AcceptedPublic

Authored by kevans on Thu, Jun 25, 4:30 PM.
Tags
None
Referenced Files
F160757538: D57848.id180634.diff
Sat, Jun 27, 1:04 PM
F160750561: D57848.id180634.diff
Sat, Jun 27, 12:10 PM
Unknown Object (File)
Fri, Jun 26, 2:49 PM
Unknown Object (File)
Fri, Jun 26, 4:35 AM
Unknown Object (File)
Thu, Jun 25, 10:22 PM
Subscribers

Details

Reviewers
kib
markj
Summary

Attempting to handle the error gracefully can easily result in missing
SIGSYS, so this was made to always succeed in
39024a89146 ("syscalls: fix missing SIGSYS for several ENOSYS errors")
and returns the nosys entry on failure.

Drop the pretense of returning an error and clean up a few dead error
paths.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 74259
Build 71142: arc lint + arc unit

Event Timeline

sys/kern/kern_sig.c
2743

I prefer the place for the saved errno to be called nerror still. It is even useful that error would disappear.

kevans marked an inline comment as done.

error back to nerror

This revision is now accepted and ready to land.Thu, Jun 25, 4:43 PM