Page MenuHomeFreeBSD
Differential D57244

sigqueue: In capability mode, only allow signalling self
ClosedPublic
Actions

Authored by emaste on Tue, May 26, 1:26 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jun 22, 2:04 AM
Unknown Object (File)
Sat, Jun 20, 5:37 PM
Unknown Object (File)
Sat, Jun 20, 11:13 AM
Unknown Object (File)
Wed, Jun 17, 6:21 PM
Unknown Object (File)
Tue, Jun 9, 4:00 AM
Unknown Object (File)
Tue, Jun 9, 4:00 AM
Unknown Object (File)
Tue, Jun 9, 3:29 AM
Unknown Object (File)
Tue, Jun 9, 3:25 AM
View All 35 Files
Subscribers
imp
markj
olce

Details

Reviewers
markj
oshogbo
Group Reviewers
capsicum
Commits
rG871d33e8a66a: sigqueue: In capability mode, only allow signalling self
rG77ee83d12625: sigqueue: In capability mode, only allow signalling self
rGeab757f954ed: sigqueue: In capability mode, only allow signalling self
rGf56e8cb94df6: sigqueue: In capability mode, only allow signalling self
rGd11ff01b3aec: sigqueue: In capability mode, only allow signalling self
rGdefd9b86ef99: sigqueue: In capability mode, only allow signalling self
rGb9d16b7fd2fa: sigqueue: In capability mode, only allow signalling self
Summary
This is equivalent to the check in kern_kill.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

emaste requested review of this revision.Tue, May 26, 1:26 PM
emaste created this revision.
emaste added a reviewer: capsicum.
emaste updated this revision to Diff 178607.Tue, May 26, 1:55 PM

Add a (not even build tested yet) test

markj added a subscriber: markj.Tue, May 26, 2:18 PM

Shall we update the kill test in tests/sys/capsicum/capmode.cc to verify sigqueue too?

markj added a comment.Tue, May 26, 2:18 PM
In D57244#1311781, @markj wrote:

Shall we update the kill test in tests/sys/capsicum/capmode.cc to verify sigqueue too?

Sorry, I had an old copy of the review open, didn't see the update.

markj accepted this revision.Tue, May 26, 2:19 PM
This revision is now accepted and ready to land.Tue, May 26, 2:19 PM
oshogbo accepted this revision.Tue, May 26, 2:24 PM
Closed by commit rGb9d16b7fd2fa: sigqueue: In capability mode, only allow signalling self (authored by emaste). · Explain WhyTue, May 26, 7:19 PM
This revision was automatically updated to reflect the committed changes.
emaste added a commit: rGb9d16b7fd2fa: sigqueue: In capability mode, only allow signalling self.
Herald added subscribers: olce, imp. · View Herald TranscriptTue, May 26, 7:19 PM
emaste added a commit: rGdefd9b86ef99: sigqueue: In capability mode, only allow signalling self.Fri, May 29, 7:12 PM
emaste added a commit: rGd11ff01b3aec: sigqueue: In capability mode, only allow signalling self.
markj added a commit: rGf56e8cb94df6: sigqueue: In capability mode, only allow signalling self.Tue, Jun 9, 7:18 PM
markj added a commit: rGeab757f954ed: sigqueue: In capability mode, only allow signalling self.
markj added a commit: rG77ee83d12625: sigqueue: In capability mode, only allow signalling self.
markj added a commit: rG871d33e8a66a: sigqueue: In capability mode, only allow signalling self.Tue, Jun 9, 7:21 PM

Revision Contents
Changeset List

PathSize
sys/
kern/
10 lines
tests/
sys/
capsicum/
12 lines

Diff 178654

View Options

sys/kern/kern_sig.c

Loading...
View Options

tests/sys/capsicum/capmode.cc

Loading...