Paths

Table of Contentst

Differential D56642

libpkgconf: Fix paths
ClosedPublic
Actions

Authored by des on Sun, Apr 26, 9:27 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, May 18, 12:35 PM

	Unknown Object (File)
	Mon, May 18, 12:27 PM

	Unknown Object (File)
	Thu, May 14, 12:36 PM

	Unknown Object (File)
	Wed, May 13, 9:25 PM

	Unknown Object (File)
	Wed, May 13, 5:35 PM

	Unknown Object (File)
	Mon, May 11, 7:08 AM

	Unknown Object (File)
	Thu, May 7, 12:45 PM

	Unknown Object (File)
	Thu, May 7, 11:05 AM

View All 21 Files

Subscribers

Details

Reviewers

antoine
khorben

Commits

rG4dd97955e68d: libpkgconf: Fix paths

Summary

${LOCALBASE:U} evaluates to exactly the same thing as ${LOCALBASE}.
Presumably what was meant was ${LOCALBASE:U/usr/local}.

Fixes: b8352da33f34 ("pkgconf: import into the base system")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

des created this revision.Sun, Apr 26, 9:27 AM

Herald added subscribers: jrtc27, imp. · View Herald TranscriptSun, Apr 26, 9:27 AM

des requested review of this revision.Sun, Apr 26, 9:27 AM

Harbormaster completed remote builds in B72552: Diff 176555.Sun, Apr 26, 9:27 AM

LGTM, thanks!

This revision is now accepted and ready to land.Sun, Apr 26, 10:44 AM

Closed by commit rG4dd97955e68d: libpkgconf: Fix paths (authored by des). · Explain WhySun, Apr 26, 1:43 PM

This revision was automatically updated to reflect the committed changes.

des added a commit: rG4dd97955e68d: libpkgconf: Fix paths.

ngie added a subscriber: ngie.Mon, Apr 27, 11:26 PM

ngie added inline comments.

lib/libpkgconf/Makefile
16	Why not just do this instead? `LOCALBASE?= /usr/local` instead of all of the `:U/usr/local` gymnastics? It avoids duplicate lines with `LOCALBASE` defaulting to `/usr/local` and reduces the potential for typos creeping in.

des added inline comments.Tue, Apr 28, 10:31 AM

lib/libpkgconf/Makefile
16	This is the predominant idiom for existing uses of `${LOCALBASE}` in the tree.

Revision Contents
Changeset List

Path

Size

lib/

libpkgconf/

4 lines

tools/

build/

depend-cleanup.sh

4 lines

Diff 176576

lib/libpkgconf/Makefile

Loading...

tools/build/depend-cleanup.sh

Loading...