Page MenuHomeFreeBSD
Differential D55733

linuxkpi: Define `CONFIG_PGTABLE_LEVELS`
Needs ReviewPublic
Actions

Authored by dumbbell on Sun, Mar 8, 1:21 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 19, 10:35 PM
Unknown Object (File)
Tue, Mar 17, 4:36 PM
Unknown Object (File)
Mon, Mar 16, 9:40 PM
Unknown Object (File)
Fri, Mar 13, 5:18 PM
Unknown Object (File)
Wed, Mar 11, 12:55 AM
Subscribers
bz
emaste
imp

Details

Reviewers
bz
Group Reviewers
linuxkpi
Summary

This is a kernel configuration constant that is expected to be defined.

The DRM generic code started to use it in Linux 6.11.

This is part of the update of DRM drivers to Linux 6.11.

Sponsored by: The FreeBSD Foundation

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

dumbbell created this revision.Sun, Mar 8, 1:21 PM
Herald added subscribers: emaste, imp. · View Herald TranscriptSun, Mar 8, 1:21 PM
dumbbell requested review of this revision.Sun, Mar 8, 1:21 PM
emaste added inline comments.Sun, Mar 8, 3:34 PM
sys/compat/linuxkpi/common/include/linux/kconfig.h
96

is this not a dup definition?

dumbbell marked an inline comment as done.Sun, Mar 8, 8:54 PM
dumbbell added inline comments.
sys/compat/linuxkpi/common/include/linux/kconfig.h
96

It is; fixing it.

dumbbell updated this revision to Diff 173385.Sun, Mar 8, 8:55 PM
dumbbell marked an inline comment as done.

Fix duplicate define as reported by @emaste

bz accepted this revision.Sun, Mar 29, 11:11 PM
bz added a subscriber: bz.

I would assume this is to be passed in by a Makefile but let's keep it here for now.
I have no idea what it means if they don't agree with our native ones or with what Linux thinks of it.
A comment in the commit message about if they are Linux or FreeBSD or matching versions would likely be good.

This revision is now accepted and ready to land.Sun, Mar 29, 11:11 PM
bz requested changes to this revision.Sun, Mar 29, 11:32 PM
bz added inline comments.
sys/compat/linuxkpi/common/include/linux/kconfig.h
75–110

Maybe an inline comment where these values come from (or what they should match) would be preferable than the commit message.
I see troubles coming our way when this changes left or right one day again.

This revision now requires changes to proceed.Sun, Mar 29, 11:32 PM
dumbbell updated this revision to Diff 174757.Wed, Apr 1, 10:32 PM

Add a comment to indicate the source of the defined constant in Linux. This addresses @bz concerns.

dumbbell marked an inline comment as done.Wed, Apr 1, 10:33 PM
bz added a comment.Thu, Apr 2, 12:38 AM

I think I didn't mean the exact files as they'll be going stable anyway; from what I get it's something like this probably be put into better English:

/*
 * The CONFIG_PGTABLE_LEVELS values are derived from the config system
 * of Linux, and matching the per-arch values there.
 */

as opposed to "The .. values were adjusted to match the FreeBSD equivalents of .."

Revision Contents
Changeset List

PathSize
sys/
compat/
linuxkpi/
common/
include/
linux/
35 lines

Diff 174757

View Options

sys/compat/linuxkpi/common/include/linux/kconfig.h

Loading...