Differential D55730

linuxkpi: Move `_RET_IP_` to <linux/instruction_pointer.h>
Needs ReviewPublic
Actions

Authored by dumbbell on Sun, Mar 8, 1:18 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Mar 13, 2:34 AM

	Unknown Object (File)
	Wed, Mar 11, 10:39 PM

	Unknown Object (File)
	Wed, Mar 11, 7:38 AM

	Unknown Object (File)
	Wed, Mar 11, 5:14 AM

	Unknown Object (File)
	Wed, Mar 11, 4:49 AM

	Unknown Object (File)
	Wed, Mar 11, 2:27 AM

Subscribers

Details

Reviewers

Group Reviewers

Summary

This matches the declaration on Linux.

Sponsored by: The FreeBSD Foundation

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

dumbbell created this revision.Sun, Mar 8, 1:18 PM

Herald added subscribers: emaste, imp. · View Herald TranscriptSun, Mar 8, 1:18 PM

dumbbell requested review of this revision.Sun, Mar 8, 1:18 PM

dumbbell edited the summary of this revision. (Show Details)

bz added subscribers: nc, bz.Sun, Mar 8, 1:37 PM

bz added inline comments.

sys/compat/linuxkpi/common/include/linux/instruction_pointer.h
8	In theory the definition came from fee0d486ef34c by @nc (https://reviews.freebsd.org/D30707)

emaste accepted this revision as: emaste.Sun, Mar 8, 3:19 PM

emaste added inline comments.

sys/compat/linuxkpi/common/include/linux/instruction_pointer.h
8	It did, although that commit did not add a copyright statement to the file it was added to. I think it doesn't much matter for the trivial content in this file. We can add a @nc copyright, but I think it would be the first one in the tree.

This revision is now accepted and ready to land.Sun, Mar 8, 3:19 PM

imp added inline comments.Sun, Mar 8, 3:37 PM

sys/compat/linuxkpi/common/include/linux/instruction_pointer.h
8	Is nc a big contrubutor? But all the ip in this file is from nc, so the copyright is misleading... Also, i thought FF contracts were doing spdx exclusively now

emaste added inline comments.Sun, Mar 8, 3:40 PM

sys/compat/linuxkpi/common/include/linux/instruction_pointer.h
8	Yes, for FF-sponsored work we can use SPDX-only.

Fix copyright header and restore copyright of @nc

This revision now requires review to proceed.Sun, Mar 8, 8:52 PM

Revision Contents
Changeset List

Path

Size

sys/

compat/

linuxkpi/

common/

include/

linux/

instruction_pointer.h

13 lines

3 lines

Diff 173381

sys/compat/linuxkpi/common/include/linux/instruction_pointer.h

Loading...

sys/compat/linuxkpi/common/include/linux/kernel.h

Loading...