Differential D55730

linuxkpi: Move `_RET_IP_` to <linux/instruction_pointer.h>
ClosedPublic
Actions

Authored by dumbbell on Mar 8 2026, 1:18 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, May 18, 12:06 PM

	Unknown Object (File)
	Mon, May 18, 12:02 PM

	Unknown Object (File)
	Mon, May 18, 2:20 AM

	Unknown Object (File)
	Mon, May 18, 2:15 AM

	Unknown Object (File)
	Sun, May 17, 3:25 PM

	Unknown Object (File)
	Sun, May 17, 10:48 AM

	Unknown Object (File)
	Sun, May 17, 12:44 AM

	Unknown Object (File)
	Sat, May 16, 6:31 PM

View All 43 Files

Subscribers

Details

Reviewers

emaste
bz

Group Reviewers

Commits

rG7ba86edecbb0: linuxkpi: Move `_RET_IP_` to <linux/instruction_pointer.h>
rG8af854ea479a: linuxkpi: Move `_RET_IP_` to <linux/instruction_pointer.h>

Summary

This matches the declaration on Linux.

Sponsored by: The FreeBSD Foundation

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

dumbbell created this revision.Mar 8 2026, 1:18 PM

Herald added subscribers: emaste, imp. · View Herald TranscriptMar 8 2026, 1:18 PM

dumbbell requested review of this revision.Mar 8 2026, 1:18 PM

dumbbell edited the summary of this revision. (Show Details)

bz added subscribers: nc, bz.Mar 8 2026, 1:37 PM

bz added inline comments.

sys/compat/linuxkpi/common/include/linux/instruction_pointer.h
7	In theory the definition came from fee0d486ef34c by @nc (https://reviews.freebsd.org/D30707)

emaste accepted this revision as: emaste.Mar 8 2026, 3:19 PM

emaste added inline comments.

sys/compat/linuxkpi/common/include/linux/instruction_pointer.h
7	It did, although that commit did not add a copyright statement to the file it was added to. I think it doesn't much matter for the trivial content in this file. We can add a @nc copyright, but I think it would be the first one in the tree.

This revision is now accepted and ready to land.Mar 8 2026, 3:19 PM

imp added inline comments.Mar 8 2026, 3:37 PM

sys/compat/linuxkpi/common/include/linux/instruction_pointer.h
7	Is nc a big contrubutor? But all the ip in this file is from nc, so the copyright is misleading... Also, i thought FF contracts were doing spdx exclusively now

emaste added inline comments.Mar 8 2026, 3:40 PM

sys/compat/linuxkpi/common/include/linux/instruction_pointer.h
7	Yes, for FF-sponsored work we can use SPDX-only.

Fix copyright header and restore copyright of @nc

This revision now requires review to proceed.Mar 8 2026, 8:52 PM

bz accepted this revision.Mar 29 2026, 11:06 PM

This revision is now accepted and ready to land.Mar 29 2026, 11:06 PM

emaste accepted this revision.Mar 29 2026, 11:57 PM

Closed by commit rG8af854ea479a: linuxkpi: Move `_RET_IP_` to <linux/instruction_pointer.h> (authored by dumbbell). · Explain WhyApr 6 2026, 7:55 PM

This revision was automatically updated to reflect the committed changes.

dumbbell added a commit: rG8af854ea479a: linuxkpi: Move `_RET_IP_` to <linux/instruction_pointer.h>.

bz added a commit: rG7ba86edecbb0: linuxkpi: Move `_RET_IP_` to <linux/instruction_pointer.h>.Wed, Apr 22, 9:12 PM

Revision Contents
Changeset List

Path

Size

sys/

compat/

linuxkpi/

common/

include/

linux/

instruction_pointer.h

35 lines

3 lines

Diff 173348

sys/compat/linuxkpi/common/include/linux/instruction_pointer.h

Loading...

sys/compat/linuxkpi/common/include/linux/kernel.h

Loading...