Page MenuHomeFreeBSD

universe: allow moving build logs to UNIVERSE_LOGDIR
ClosedPublic

Authored by siva on Feb 27 2026, 4:51 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jun 6, 12:34 PM
Unknown Object (File)
Fri, Jun 5, 5:24 AM
Unknown Object (File)
Fri, Jun 5, 1:47 AM
Unknown Object (File)
Thu, Jun 4, 12:44 PM
Unknown Object (File)
Thu, Jun 4, 11:14 AM
Unknown Object (File)
Thu, Jun 4, 6:00 AM
Unknown Object (File)
Thu, Jun 4, 3:13 AM
Unknown Object (File)
Tue, Jun 2, 5:17 AM
Subscribers

Details

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

siva requested review of this revision.Feb 27 2026, 4:51 PM
siva created this revision.

I actually find it really convenient that the log files are in .CURDIR.

I think the convenience is nice for sure, but the flexibility of choice is reduced. If anything, maybe I can add a variable similar to FAILFILE that is configurable so that users can choose where it goes?

I do like the idea of being able to build from a read-only src tree.

How about this instead? This keeps the old behaviour by default
for backwards compatibility.

siva retitled this revision from universe: move build logs to OBJROOT to universe: allow moving build logs to TINDERBOX_LOGDIR.Apr 7 2026, 8:58 PM
delphij added a subscriber: delphij.

Looks fine to me.

This revision is now accepted and ready to land.Apr 9 2026, 12:35 AM

My only suggestion would be to be consistent and apply this to make universe as well. That is, I would call this UNIVERSE_LOGDIR and move it out of the DOING_TINDERBOX check. This should also be documented in build(7), but I like the idea overall.

siva retitled this revision from universe: allow moving build logs to TINDERBOX_LOGDIR to universe: allow moving build logs to UNIVERSE_LOGDIR.

Thanks, that makes more sense. Updated the diff now, and also removed an unnecessary check against DOING_TINDERBOX because rm -f succeeds when the file doesn't exist anyway.

This revision now requires review to proceed.Apr 24 2026, 3:47 PM

Added documentation in build(7).

This revision is now accepted and ready to land.May 6 2026, 9:19 PM

Other than bumping .Dd of the manpage, LGTM.