Page MenuHomeFreeBSD
Differential D54511

Add ASMC_DEBUG make option
ClosedPublic
Actions

Authored by ngie on Mon, Jan 5, 3:27 AM.
Tags
None
Referenced Files
F141940779: D54511.diff
Tue, Jan 13, 4:26 PM
F141940531: D54511.id169145.diff
Tue, Jan 13, 4:11 PM
F141927571: D54511.diff
Mon, Jan 12, 9:04 PM
F141875583: D54511.diff
Sun, Jan 11, 8:35 PM
Unknown Object (File)
Fri, Jan 9, 2:39 PM
Unknown Object (File)
Fri, Jan 9, 5:46 AM
Unknown Object (File)
Wed, Jan 7, 2:51 PM
Unknown Object (File)
Wed, Jan 7, 11:00 AM
View All 17 Files
Subscribers
guest-seuros
imp

Details

Reviewers
adrian
markj
Commits
rGf224591746bd: Add ASMC_DEBUG make option
Summary

This allows folks to enable debug statements in asmc(4) using kernel
configs via the options ASMC_DEBUG directive.

Remove a duplicate device vt_efifb directive in NOTES as it's
already handled in the GENERIC config.

MFC after: 1 week

Test Plan

This allows me to see the debug statements from asmc_dumpall, etc, on my MacBookPro16,1.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ngie created this revision.Mon, Jan 5, 3:27 AM
Herald added a subscriber: imp. · View Herald TranscriptMon, Jan 5, 3:27 AM
ngie requested review of this revision.Mon, Jan 5, 3:27 AM
Harbormaster completed remote builds in B69610: Diff 169034.Mon, Jan 5, 3:27 AM
ngie added reviewers: adrian, markj.Mon, Jan 5, 3:28 AM
ngie edited the test plan for this revision. (Show Details)
ngie added a subscriber: guest-seuros.
ngie edited the summary of this revision. (Show Details)Mon, Jan 5, 3:30 AM
ngie added inline comments.Mon, Jan 5, 7:16 AM
sys/modules/asmc/Makefile
4–6

This can be condensed.

ngie updated this revision to Diff 169047.Mon, Jan 5, 8:05 AM

sys/modules/asmc/Makefile: condense SRCS

Harbormaster completed remote builds in B69618: Diff 169047.Mon, Jan 5, 8:05 AM
markj accepted this revision.Mon, Jan 5, 1:33 PM

You might mention this option in asmc.4 too.

This revision is now accepted and ready to land.Mon, Jan 5, 1:33 PM
Closed by commit rGf224591746bd: Add ASMC_DEBUG make option (authored by ngie). · Explain WhyTue, Jan 6, 1:43 AM
This revision was automatically updated to reflect the committed changes.
ngie added a commit: rGf224591746bd: Add ASMC_DEBUG make option.

Revision Contents
Changeset List

PathSize
sys/
amd64/
conf/
7 lines
conf/
3 lines
dev/
asmc/
20 lines
modules/
asmc/
2 lines

Diff 169145

View Options

sys/amd64/conf/NOTES

Loading...
View Options

sys/conf/options.amd64

Loading...
View Options

sys/dev/asmc/asmc.c

Loading...
View Options

sys/modules/asmc/Makefile

Loading...