snd_hda: Default to 256 when corb/rirb is invalid
ClosedPublic
Actions

Authored by christos on Mon, Dec 22, 5:52 PM.

Details

Reviewers

markj
emaste

Commits

rGed61d50bd404: snd_hda: Default to 256 when corb/rirb is invalid
rG2455db44ef08: snd_hda: Default to 256 when corb/rirb is invalid

Summary

PR: 289284
MFC after: 1 week

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

christos created this revision.Mon, Dec 22, 5:52 PM

Herald added a subscriber: imp. · View Herald TranscriptMon, Dec 22, 5:52 PM

christos requested review of this revision.Mon, Dec 22, 5:52 PM

Harbormaster completed remote builds in B69439: Diff 168524.Mon, Dec 22, 5:52 PM

From the PR submitted on Bugzilla:

Thank you for the fast fix! I can confirm that your patch works great.

emaste accepted this revision.Tue, Dec 23, 2:23 PM

emaste added inline comments.

sys/dev/sound/pci/hda/hdac.c
548–549	Perhaps something like "Hardware reports invalid corb size"? Mainly I'm thinking about what a user who reads a kernel message will think or should do, and in this case there's no action for them to take.

This revision is now accepted and ready to land.Tue, Dec 23, 2:23 PM

Closed by commit rG2455db44ef08: snd_hda: Default to 256 when corb/rirb is invalid (authored by christos). · Explain WhyFri, Jan 2, 3:50 PM

This revision was automatically updated to reflect the committed changes.

christos added a commit: rG2455db44ef08: snd_hda: Default to 256 when corb/rirb is invalid.

christos added a commit: rGed61d50bd404: snd_hda: Default to 256 when corb/rirb is invalid.Fri, Jan 9, 11:27 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

sound/

pci/

hda/

hdac.c

14 lines

Diff 168880

View Options

sys/dev/sound/pci/hda/hdac.c

snd_hda: Default to 256 when corb/rirb is invalidClosedPublicActions