Page MenuHomeFreeBSD
Differential D54339

snd_hda: Default to 256 when corb/rirb is invalid
AcceptedPublic
Actions

Authored by christos on Mon, Dec 22, 5:52 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Dec 24, 7:38 AM
Unknown Object (File)
Tue, Dec 23, 9:23 PM
Unknown Object (File)
Tue, Dec 23, 1:52 AM
Subscribers
imp

Details

Reviewers
markj
emaste
Summary

PR: 289284
MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 69439
Build 66322: arc lint + arc unit

Event Timeline

christos created this revision.Mon, Dec 22, 5:52 PM
Herald added a subscriber: imp. · View Herald TranscriptMon, Dec 22, 5:52 PM
christos requested review of this revision.Mon, Dec 22, 5:52 PM
Harbormaster completed remote builds in B69439: Diff 168524.Mon, Dec 22, 5:52 PM
christos added a comment.Tue, Dec 23, 2:17 PM

From the PR submitted on Bugzilla:

Thank you for the fast fix! I can confirm that your patch works great.

emaste accepted this revision.Tue, Dec 23, 2:23 PM
emaste added inline comments.
sys/dev/sound/pci/hda/hdac.c
548

Perhaps something like "Hardware reports invalid corb size"? Mainly I'm thinking about what a user who reads a kernel message will think or should do, and in this case there's no action for them to take.

This revision is now accepted and ready to land.Tue, Dec 23, 2:23 PM

Revision Contents
Changeset List

PathSize
sys/
dev/
sound/
pci/
hda/
14 lines

Diff 168524

View Options

sys/dev/sound/pci/hda/hdac.c

Loading...