LinuxKPI: Move vmap-related code from linux_compat.c to linux_page.c
ClosedPublic
Actions

Authored by wulf on Sun, Dec 14, 10:05 PM.

Details

Reviewers

bz
dumbbell

Group Reviewers

linuxkpi

Commits

rGbbc5f5483723: LinuxKPI: Move vmap-related code from linux_compat.c to linux_page.c
rG20ce906157df: LinuxKPI: Move vmap-related code from linux_compat.c to linux_page.c

Summary

Coming vmap_pfn() implementation requires is_vmalloc_addr() to be in
the same file with other vmap-related code. So move code out from
the overcrowded file. No functional changes intended.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 69251
Build 66134: arc lint + arc unit

Event Timeline

wulf created this revision.Sun, Dec 14, 10:05 PM

Herald added subscribers: linuxkpi, emaste, imp. · View Herald TranscriptSun, Dec 14, 10:05 PM

wulf requested review of this revision.Sun, Dec 14, 10:05 PM

Harbormaster completed remote builds in B69251: Diff 168023.Sun, Dec 14, 10:05 PM

bz added a reviewer: linuxkpi.Sun, Dec 14, 10:11 PM

This should be joined with D54226

wulf mentioned this in D54226: LinuxKPI: Factor out _lkpi_vunmap() function.Sun, Dec 14, 10:13 PM

Otherwise (assuming the migrating code from one file to the other is a clean move), this seems fine.

sys/compat/linuxkpi/common/src/linux_page.c
687	Please call this lkpi_page_init()
698	Please call this lkpi_page_uninit()

This revision now requires changes to proceed.Sun, Dec 14, 10:17 PM

s/linux_/lkpi_/ in function names

Harbormaster completed remote builds in B69256: Diff 168028.Sun, Dec 14, 10:40 PM

wulf marked 2 inline comments as done.Sun, Dec 14, 10:42 PM

wulf added a child revision: D54226: LinuxKPI: Factor out _lkpi_vunmap() function.Sun, Dec 14, 10:44 PM

bz accepted this revision.Sun, Dec 14, 10:58 PM

bz added inline comments.

sys/compat/linuxkpi/common/src/linux_page.c
695	Sorry, I missed pointing this out; you could probably also call the uniquifier "lkpi_page" in both SYS(UN)INIT cases. Otherwise this can go in. And I'll be happy to use the SYSINITs as well later with some other work in progress :)