Page MenuHomeFreeBSD

linuxkpi: Avoid trailing whitespaces in lkpi_hex_dump()
Needs ReviewPublic

Authored by dumbbell on Jul 26 2025, 3:51 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Oct 9, 11:24 AM
Unknown Object (File)
Thu, Oct 9, 11:24 AM
Unknown Object (File)
Thu, Oct 9, 11:24 AM
Unknown Object (File)
Thu, Oct 9, 11:18 AM
Unknown Object (File)
Fri, Oct 3, 12:42 PM
Unknown Object (File)
Thu, Oct 2, 9:06 AM
Unknown Object (File)
Wed, Oct 1, 11:06 PM
Unknown Object (File)
Wed, Oct 1, 3:23 AM
Subscribers

Details

Reviewers
bz
Group Reviewers
linuxkpi
Summary

We use the return value of the callback to track the number of bytes written. We use it to determine if a group of characters should be prepended with a whitespace. This way, we never add a trailing whitespace.

We need to pay attention to the return value of the callback: if it is negative, it's an error and we return immediately. Otherwise, we would decrease the number of written bytes and possibly make it negative.

Sponsored by: The FreeBSD Foundation

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

bz requested changes to this revision.Jul 30 2025, 9:18 AM
bz added a subscriber: bz.

As pointed out in the other review; the callback functions can return negative values; you need to catch those and make sure you do not go negative or backwards.

This revision now requires changes to proceed.Jul 30 2025, 9:18 AM

Handle negative return value from callback.