Page MenuHomeFreeBSD
Differential D54223

LinuxKPI: Move vmap-related code from linux_compat.c to linux_page.c
AcceptedPublic
Actions

Authored by wulf on Sun, Dec 14, 10:05 PM.
Tags
None
Referenced Files
F139727192: D54223.id168028.diff
Mon, Dec 15, 10:14 AM
F139726100: D54223.id168023.diff
Mon, Dec 15, 9:51 AM
F139725738: D54223.id.diff
Mon, Dec 15, 9:44 AM
F139724748: D54223.diff
Mon, Dec 15, 9:25 AM
Subscribers
emaste
imp
linuxkpi

Details

Reviewers
bz
dumbbell
Group Reviewers
linuxkpi
Summary

Coming vmap_pfn() implementation requires is_vmalloc_addr() to be in
the same file with other vmap-related code. So move code out from
the overcrowded file. No functional changes intended.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 69256
Build 66139: arc lint + arc unit

Event Timeline

wulf created this revision.Sun, Dec 14, 10:05 PM
Herald added subscribers: linuxkpi, emaste, imp. · View Herald TranscriptSun, Dec 14, 10:05 PM
wulf requested review of this revision.Sun, Dec 14, 10:05 PM
Harbormaster completed remote builds in B69251: Diff 168023.Sun, Dec 14, 10:05 PM
bz added a reviewer: linuxkpi.Sun, Dec 14, 10:11 PM
wulf added a comment.Sun, Dec 14, 10:12 PM

This should be joined with D54226

wulf mentioned this in D54226: LinuxKPI: Factor out _lkpi_vunmap() function.Sun, Dec 14, 10:13 PM
bz requested changes to this revision.Sun, Dec 14, 10:17 PM

Otherwise (assuming the migrating code from one file to the other is a clean move), this seems fine.

sys/compat/linuxkpi/common/src/linux_page.c
687

Please call this lkpi_page_init()

698

Please call this lkpi_page_uninit()

This revision now requires changes to proceed.Sun, Dec 14, 10:17 PM
wulf updated this revision to Diff 168028.Sun, Dec 14, 10:40 PM

s/linux_/lkpi_/ in function names

Harbormaster completed remote builds in B69256: Diff 168028.Sun, Dec 14, 10:40 PM
wulf marked 2 inline comments as done.Sun, Dec 14, 10:42 PM
wulf added a child revision: D54226: LinuxKPI: Factor out _lkpi_vunmap() function.Sun, Dec 14, 10:44 PM
bz accepted this revision.Sun, Dec 14, 10:58 PM
bz added inline comments.
sys/compat/linuxkpi/common/src/linux_page.c
695

Sorry, I missed pointing this out; you could probably also call the uniquifier "lkpi_page" in both SYS(UN)INIT cases.

Otherwise this can go in. And I'll be happy to use the SYSINITs as well later with some other work in progress :)

This revision is now accepted and ready to land.Sun, Dec 14, 10:58 PM

Revision Contents
Changeset List

PathSize
sys/
compat/
linuxkpi/
common/
src/
111 lines
125 lines

Diff 168028

View Options

sys/compat/linuxkpi/common/src/linux_compat.c

Loading...
View Options

sys/compat/linuxkpi/common/src/linux_page.c

Loading...