Page MenuHomeFreeBSD

pf: fix another endpoint-independent crash
ClosedPublic

Authored by kp on Fri, Nov 21, 1:24 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 24, 6:38 AM
Unknown Object (File)
Sun, Nov 23, 5:41 AM
Unknown Object (File)
Sat, Nov 22, 9:57 AM
Unknown Object (File)
Sat, Nov 22, 9:56 AM
Unknown Object (File)
Sat, Nov 22, 9:55 AM
Unknown Object (File)
Sat, Nov 22, 9:43 AM
Unknown Object (File)
Fri, Nov 21, 10:22 PM
Unknown Object (File)
Fri, Nov 21, 7:48 PM

Details

Summary

In c12013f5bb38 we fixed udp_mapping cleanup issues in pf_get_sport(), but
missed the static-port case (i.e. low == 0 && high == 0). We could still exit
pf_get_sport() without either inserting the udp_mapping or freeing it.

Address this and add a test case to provoke the problem.

MFC after: 1 week
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable