Page MenuHomeFreeBSD

pf: fix another endpoint-independent crash
ClosedPublic

Authored by kp on Fri, Nov 21, 1:24 PM.
Tags
None
Referenced Files
F137237452: D53856.id166889.diff
Fri, Nov 21, 5:19 PM
F137236159: D53856.id.diff
Fri, Nov 21, 5:01 PM
F137235364: D53856.id166889.diff
Fri, Nov 21, 4:50 PM
F137233903: D53856.diff
Fri, Nov 21, 4:30 PM

Details

Summary

In c12013f5bb38 we fixed udp_mapping cleanup issues in pf_get_sport(), but
missed the static-port case (i.e. low == 0 && high == 0). We could still exit
pf_get_sport() without either inserting the udp_mapping or freeing it.

Address this and add a test case to provoke the problem.

MFC after: 1 week
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable