nvme: Add handling for bar5

[jtranoleary_google.com]

Summary

The NVMe spec allows the Table BIR (TBIR) and PBA DIR (PBIR) to
be 0, 4, or 5. The existing NVMe driver basically only has support
for 4, perhaps under the assumption that BAR4 is 64-bit and also
occupies BAR5.

This change adds support for BAR5, covering the case where BAR4
and BAR5 might both be present and 32-bit, where the Table BIR
might be 4 and the PBA BIR might be 5, or vice versa.

The NVMe spec (in the SR-IOV section) also permits VFs to use BIR=2,
so I haven't added stricter checks on which BIR will be permitted
by the driver.

Co-authored-by: Matt Delco <[e-mail]>
Signed-off-by: Jasper Tran O'Leary <[e-mail]>

[imp]

sys/dev/nvme/nvme_ctrlr.c

1773

double free if these are the same BAR?

[imp]

This looks good to me... Never mind my earlier misreading.

sys/dev/nvme/nvme_ctrlr.c

1773

oh! I confused the _id and _resource variables.

[jtranoleary_google.com]

This comment was removed by jtranoleary_google.com.

[ziaee]

I will commit this, with MFC to all supported branches, as soon as my CI finishes.