Page MenuHomeFreeBSD
Differential D53033

zfs: Emit warning upon use of legacy sysctl
Needs ReviewPublic
Actions

Authored by emaste on Fri, Oct 10, 8:46 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Oct 11, 1:11 AM
Unknown Object (File)
Sat, Oct 11, 12:12 AM
Unknown Object (File)
Sat, Oct 11, 12:09 AM
Unknown Object (File)
Sat, Oct 11, 12:09 AM
Unknown Object (File)
Fri, Oct 10, 11:36 PM
Subscribers
delphij
freqlabs
jlduran

Details

Reviewers
mm
Group Reviewers
releng
ZFS
Summary
PR:             266374

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

emaste created this revision.Fri, Oct 10, 8:46 PM
Herald added a subscriber: delphij. · View Herald TranscriptFri, Oct 10, 8:46 PM
emaste requested review of this revision.Fri, Oct 10, 8:46 PM
emaste added inline comments.Fri, Oct 10, 11:40 PM
sys/contrib/openzfs/module/os/freebsd/zfs/sysctl_os.c
754

AFAICT min_auto_ashift/max_auto_ashift did not use arg1/arg2 before, I imagine this was just done without being required.

emaste added a subscriber: freqlabs.Sat, Oct 11, 6:32 PM
jlduran added a subscriber: jlduran.Sun, Oct 12, 12:51 PM
jlduran added inline comments.
sys/contrib/openzfs/module/os/freebsd/zfs/sysctl_os.c
167

I would rather take an old, new tuple with the full sysctl instead, as it is not a 1:1 translation:

oldnew
vfs.zfs.arc_maxvfs.zfs.arc.max
vfs.zfs.arc_minvfs.zfs.arc.min
vfs.zfs.arc_free_targetvfs.zfs.arc.free_target
vfs.zfs.arc_no_grow_shiftvfs.zfs.arc.no_grow_shift
vfs.zfs.max_auto_ashiftvfs.zfs.vdev.max_auto_ashift
vfs.zfs.min_auto_ashiftvfs.zfs.vdev.min_auto_ashift
jlduran added inline comments.Sun, Oct 12, 12:54 PM
sys/contrib/openzfs/module/os/freebsd/zfs/sysctl_os.c
167

Sans vfs.zfs..

emaste updated this revision to Diff 164039.Sun, Oct 12, 1:46 PM

correct mapping per @jlduran

emaste marked 2 inline comments as done.Sun, Oct 12, 1:47 PM
jlduran added a comment.Sun, Oct 12, 2:55 PM

Sorry to bother, but I have the following doubt:
There are still a few renamed LEGACY sysctls that were removed (and reverted):

oldnew
vfs.zfs.l2arc_write_maxvfs.zfs.l2arc.write_max
vfs.zfs.l2arc_write_boostvfs.zfs.l2arc.write_boost
vfs.zfs.l2arc_headroomvfs.zfs.l2arc.headroom
vfs.zfs.l2arc_headroom_boostvfs.zfs.l2arc.headroom_boost
vfs.zfs.l2arc_feed_secsvfs.zfs.l2arc.feed_secs
vfs.zfs.l2arc_feed_min_msvfs.zfs.l2arc.feed_min_ms
vfs.zfs.l2arc_noprefetchvfs.zfs.l2arc.noprefetch
vfs.zfs.l2arc_feed_againvfs.zfs.l2arc.feed_again
vfs.zfs.l2arc_norwvfs.zfs.l2arc.norw

Revision Contents
Changeset List

PathSize
sys/
contrib/
openzfs/
module/
os/
freebsd/
zfs/
41 lines

Diff 164039

View Options

sys/contrib/openzfs/module/os/freebsd/zfs/sysctl_os.c

Loading...