pkgbase: Don't include pkg by default
ClosedPublic
Actions

Authored by cperciva on Fri, Sep 19, 4:22 PM.

Details

Reviewers

Commits

rG060f7edadcff: pkgbase: Don't include pkg by default

Summary

We need to put pkg into the pkgbase repository for release builds, but
not for non-release pkgbase builds. Gate the contents of package-pkg
behind INCLUDE_PKG_IN_PKGBASE_REPO=YES and set that when building
releases.

MFC after: 6 hours
Sponsored by: https://www.patreon.com/cperciva

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

cperciva created this revision.Fri, Sep 19, 4:22 PM

Herald added subscribers: jrtc27, emaste, imp. · View Herald TranscriptFri, Sep 19, 4:22 PM

cperciva requested review of this revision.Fri, Sep 19, 4:22 PM

Harbormaster completed remote builds in B67172: Diff 162423.Fri, Sep 19, 4:22 PM

i'm still not super fond of this since it's just vendoring with extra steps, but it does fix my major complaints with the original change.

This revision is now accepted and ready to land.Fri, Sep 19, 4:25 PM

Thanks! And yeah, I don't like the whole "reaching into the ports tree to build something which should be part of base" thing, but this is where we're at right now.

Closed by commit rG060f7edadcff: pkgbase: Don't include pkg by default (authored by cperciva). · Explain WhyFri, Sep 19, 4:29 PM

This revision was automatically updated to reflect the committed changes.

cperciva added a commit: rG060f7edadcff: pkgbase: Don't include pkg by default.