Paths

Table of Contentst

Differential D52067

LinuxKPI: pci: implement pcim_iomap()
ClosedPublic
Actions

Authored by bz on Aug 21 2025, 8:58 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Aug 10, 6:11 PM

	Unknown Object (File)
	Sun, Aug 9, 7:05 AM

	Unknown Object (File)
	Sat, Aug 8, 10:31 PM

	Unknown Object (File)
	Sat, Aug 8, 10:12 AM

	Unknown Object (File)
	Sat, Aug 8, 7:02 AM

	Unknown Object (File)
	Fri, Aug 7, 2:06 AM

	Unknown Object (File)
	Thu, Aug 6, 11:59 AM

	Unknown Object (File)
	Mon, Jul 27, 11:31 AM

Subscribers

Details

Reviewers

Group Reviewers

Commits

rG008b9c7db5b2: LinuxKPI: pci: implement pcim_iomap()
rGcfb8f4bf2c2b: LinuxKPI: pci: implement pcim_iomap()
rG2f9064a5d2b5: LinuxKPI: pci: implement pcim_iomap()

Summary

Like pci_iomap() add the devres version pcim_iomap() using the former
to get the resource.

Add a helper function to validate that the bar is within a valid range
and sprinkle that check also to other related functions.

Sponsored by: The FreeBSD Foundation
MFC after: 3 days

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bz created this revision.Aug 21 2025, 8:58 AM

Herald added subscribers: emaste, imp. · View Herald TranscriptAug 21 2025, 8:58 AM

bz requested review of this revision.Aug 21 2025, 8:58 AM

Harbormaster completed remote builds in B66405: Diff 160721.Aug 21 2025, 8:58 AM

dumbbell added a subscriber: dumbbell.Sep 3 2025, 8:20 PM

dumbbell added inline comments.

sys/compat/linuxkpi/common/src/linux_pci.c
873–874	Perhaps we could put the setting of both tables in a static function to not duplicate code? The same logic is already present in `linuxkpi_pcim_iomap_regions()`. What do you think?

Factor out setting table into its own function.

Harbormaster completed remote builds in B66803: Diff 161469.Sep 3 2025, 10:32 PM

bz marked an inline comment as done.Sep 3 2025, 10:32 PM

dumbbell accepted this revision.Sep 4 2025, 4:13 PM

This revision is now accepted and ready to land.Sep 4 2025, 4:13 PM

bz added inline comments.Sep 5 2025, 8:12 PM

sys/compat/linuxkpi/common/src/linux_pci.c
148	static

Closed by commit rG2f9064a5d2b5: LinuxKPI: pci: implement pcim_iomap() (authored by bz). · Explain WhySep 5 2025, 11:29 PM

This revision was automatically updated to reflect the committed changes.

bz added a commit: rG2f9064a5d2b5: LinuxKPI: pci: implement pcim_iomap().

bz added a commit: rGcfb8f4bf2c2b: LinuxKPI: pci: implement pcim_iomap().Sep 15 2025, 7:13 PM

bz added a commit: rG008b9c7db5b2: LinuxKPI: pci: implement pcim_iomap().Jan 16 2026, 7:43 PM

Revision Contents
Changeset List

Path

Size

sys/

compat/

linuxkpi/

common/

include/

linux/

3 lines

src/

58 lines

Diff 161629

sys/compat/linuxkpi/common/include/linux/pci.h

Loading...

sys/compat/linuxkpi/common/src/linux_pci.c

Loading...