Page MenuHomeFreeBSD
Differential D51582

gpiobus: factorize common add_child code
ClosedPublic
Actions

Authored by vexeduxr on Jul 27 2025, 8:43 PM.
Tags
None
Referenced Files
F132574538: D51582.id159254.diff
Sat, Oct 18, 2:35 AM
Unknown Object (File)
Tue, Oct 14, 2:47 AM
Unknown Object (File)
Tue, Oct 14, 2:47 AM
Unknown Object (File)
Tue, Oct 14, 2:47 AM
Unknown Object (File)
Tue, Oct 14, 2:47 AM
Unknown Object (File)
Mon, Oct 13, 1:25 PM
Unknown Object (File)
Sun, Oct 12, 1:44 AM
Unknown Object (File)
Thu, Oct 9, 9:29 PM
View All 40 Files
Subscribers
loos

Details

Reviewers
imp
cperciva
mmel
andrew
jrtc27
wulf
Commits
rG7f53cf7e1e89: gpiobus: factorize common add_child code
Summary

Move common bus_add_child code to gpiobus_add_child_common.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

vexeduxr created this revision.Jul 27 2025, 8:43 PM
Herald added a subscriber: loos. · View Herald TranscriptJul 27 2025, 8:43 PM
vexeduxr requested review of this revision.Jul 27 2025, 8:43 PM
Harbormaster completed remote builds in B65784: Diff 159254.Jul 27 2025, 8:43 PM
vexeduxr added a child revision: D51584: gpio: rework gpioaei.Jul 27 2025, 8:45 PM
andrew accepted this revision.Jul 28 2025, 9:08 AM
andrew added inline comments.
sys/dev/gpio/gpiobus.c
679

Would it be useful to KASSERT ivars_size >= sizeof(struct gpiobus_ivar)?

This revision is now accepted and ready to land.Jul 28 2025, 9:08 AM
vexeduxr added inline comments.Jul 28 2025, 1:51 PM
sys/dev/gpio/gpiobus.c
679

Yes, that's a good idea.

vexeduxr updated this revision to Diff 159318.Jul 28 2025, 1:51 PM

Add KASSERT

This revision now requires review to proceed.Jul 28 2025, 1:51 PM
Harbormaster completed remote builds in B65798: Diff 159318.Jul 28 2025, 1:51 PM
This revision was not accepted when it landed; it landed in state Needs Review.Aug 20 2025, 7:00 AM
Closed by commit rG7f53cf7e1e89: gpiobus: factorize common add_child code (authored by vexeduxr). · Explain Why
This revision was automatically updated to reflect the committed changes.
vexeduxr added a commit: rG7f53cf7e1e89: gpiobus: factorize common add_child code.

Revision Contents
Changeset List

PathSize
sys/
dev/
gpio/
16 lines
1 line
14 lines

Diff 160648

View Options

sys/dev/gpio/gpiobus.c

Loading...
View Options

sys/dev/gpio/gpiobus_internal.h

Loading...
View Options

sys/dev/gpio/ofw_gpiobus.c

Loading...