Page MenuHomeFreeBSD
Differential D51487

amdsmu: Read and dump idlemask
ClosedPublic
Actions

Authored by obiwac on Jul 24 2025, 1:28 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Oct 10, 4:32 PM
Unknown Object (File)
Fri, Oct 10, 4:32 PM
Unknown Object (File)
Fri, Oct 10, 4:32 PM
Unknown Object (File)
Fri, Oct 10, 4:31 PM
Unknown Object (File)
Fri, Oct 10, 10:50 AM
Unknown Object (File)
Thu, Sep 25, 4:54 AM
Unknown Object (File)
Sep 13 2025, 6:34 AM
Unknown Object (File)
Sep 11 2025, 2:52 AM
View All 42 Files
Subscribers
None

Details

Reviewers
cem
jkim
emaste
imp
jhb
mckusick
jrm
kib
Commits
rGf2de5a6dd7bb: amdsmu: Read and dump idlemask
Summary

Read and dump SMU's idlemask value in dev.amdsmu.0.idlemask sysctl.

The idlemask is used internally by AMD and its value is not documented anywhere. This patch exposes it mainly to help AMD diagnose issues with S0i3 entry on FreeBSD.

Sponsored by: The FreeBSD Foundation

Test Plan

I have tested this on the Framework 13 AMD Ryzen 7040 series (Phoenix):

% sysctl dev.amdsmu.0.idlemask
dev.amdsmu.0.idlemask: 1071365821

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

obiwac requested review of this revision.Jul 24 2025, 1:28 PM
obiwac created this revision.
Harbormaster completed remote builds in B65652: Diff 158995.Jul 24 2025, 1:28 PM
obiwac edited the summary of this revision. (Show Details)Jul 24 2025, 1:28 PM
obiwac edited the summary of this revision. (Show Details)
obiwac added a parent revision: D48714: amdsmu: Get and expose sysctls for metrics about last sleep.
emaste added a comment.Jul 24 2025, 2:40 PM

Do we expect to remove this again in the future?

obiwac added a comment.Jul 24 2025, 2:59 PM

No, this can always be useful (e.g. debugging S0i3 on new platforms, diagnosing user issues preventing the system from entering S0i3, etc).

obiwac edited the summary of this revision. (Show Details)Jul 24 2025, 2:59 PM
cem added a comment.Jul 24 2025, 5:43 PM

Otherwise seems unobjectionable to me.

sys/dev/amdsmu/amdsmu.c
284

It's been a while, but I don't think this whitespace is style(9)?

289–296

This thing is pretty funky. Why not just do it in attach()?

obiwac updated this revision to Diff 159074.Jul 25 2025, 12:18 PM
obiwac marked 2 inline comments as done.

Simplify sysctl adding

Harbormaster completed remote builds in B65704: Diff 159074.Jul 25 2025, 12:18 PM
emaste added inline comments.Jul 25 2025, 8:25 PM
sys/dev/amdsmu/amdsmu.c
285

"dump" seems confusing in the fn name, should it be amdsmu_get_idlemask or amdsmu_fetch_idlemask maybe?

obiwac added inline comments.Jul 25 2025, 9:51 PM
sys/dev/amdsmu/amdsmu.c
285

Perhaps, it was named dump to match amdsmu_dump_metrics but maybe it should be named fetch instead.

obiwac marked an inline comment as not done.Jul 25 2025, 9:52 PM
kib accepted this revision.Jul 26 2025, 8:49 PM
This revision is now accepted and ready to land.Jul 26 2025, 8:49 PM
emaste accepted this revision.Jul 26 2025, 10:38 PM
mckusick accepted this revision.Jul 26 2025, 11:02 PM

Review process looks good and complete.
Adding my accept as your mentor.

Closed by commit rGf2de5a6dd7bb: amdsmu: Read and dump idlemask (authored by obiwac). · Explain WhyJul 27 2025, 1:25 PM
This revision was automatically updated to reflect the committed changes.
obiwac added a commit: rGf2de5a6dd7bb: amdsmu: Read and dump idlemask.

Revision Contents
Changeset List

PathSize
sys/
dev/
amdsmu/
1 line
15 lines
1 line

Diff 159226

View Options

sys/dev/amdsmu/amdsmu.h

Loading...
View Options

sys/dev/amdsmu/amdsmu.c

Loading...
View Options

sys/dev/amdsmu/amdsmu_reg.h

Loading...