release: install pkg to install media
ClosedPublic
Actions

Authored by ifreund_freebsdfoundation.org on Apr 23 2025, 7:34 AM.

Details

Reviewers

emaste
cperciva
bz

Group Reviewers

pkgbase

Commits

rG92e9301e56bd: release: install pkg to install media

Summary

This is the most straightforward way to make installation of base system
packages from install media possible. Bootstrapping pkg at install time
does not work since the root filesystem of install media is immutable.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ifreund_freebsdfoundation.org created this revision.Apr 23 2025, 7:34 AM

Herald added subscribers: jrtc27, imp. · View Herald TranscriptApr 23 2025, 7:34 AM

ifreund_freebsdfoundation.org requested review of this revision.Apr 23 2025, 7:34 AM

Harbormaster completed remote builds in B63652: Diff 154142.Apr 23 2025, 7:34 AM

ifreund_freebsdfoundation.org added a parent revision: D49822: bsdinstall: add pkgbase target.Apr 23 2025, 7:34 AM

ifreund_freebsdfoundation.org added reviewers: emaste, pkgbase.Apr 23 2025, 7:35 AM

What do you think about (perhaps as a follow-up) moving this to a function that takes a list of packages to install?

emaste accepted this revision as: emaste.Apr 23 2025, 7:02 PM

This revision is now accepted and ready to land.Apr 23 2025, 7:02 PM

releng I'm tempted to merge this change ASAP even if we don't bring in the rest of the pkgbase functionality yet, to try to get as much testing on any of the subparts as possible. Any objection?

cperciva accepted this revision.Apr 23 2025, 7:53 PM

I didn't need this for wifi as we run pkg inside the new installation later and there it gets bootstrapped automatically; this will all change now I presume :)

Here's my git branch with this commit: https://github.com/ifreund/freebsd-src/tree/install-media-pkg

In D49968#1140006, @emaste wrote:

What do you think about (perhaps as a follow-up) moving this to a function that takes a list of packages to install?

I'd be happy to refactor this in a followup, but I must admit I'm not sure what you mean by a function here? I can't seem to find anything about user-defined functions in make(1). Is there an example somewhere in the src tree you could point me to?

In D49968#1140192, @ifreund_freebsdfoundation.org wrote:

I'd be happy to refactor this in a followup, but I must admit I'm not sure what you mean by a function here? I can't seem to find anything about user-defined functions in make(1). Is there an example somewhere in the src tree you could point me to?

Oh, nevermind - somehow I confused myself and thought this was shell, or something.

guest-patmaddox added a subscriber: guest-patmaddox.Apr 24 2025, 2:00 PM

Closed by commit rG92e9301e56bd: release: install pkg to install media (authored by ifreund_freebsdfoundation.org, committed by emaste). · Explain WhyFri, Apr 25, 2:12 PM

This revision was automatically updated to reflect the committed changes.

emaste added a commit: rG92e9301e56bd: release: install pkg to install media.